This repository has been archived by the owner on Jul 10, 2020. It is now read-only.
Re-structure lint tasks #730
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jimmynotjim
suggested changes
Jan 8, 2018
scripts/gulp/lint.js
Outdated
| gulp.task( 'lint:tests', () => { | ||
| _genericLintJs( [ | ||
| function lintTests() { | ||
| return _genericLintJs( [ | ||
| 'test/accessibility/*.js', | ||
| 'test/*.js' |
There was a problem hiding this comment.
This could be simplified as test/**/*.js. Currently it's not catching any of the unit tests for atomic component
|
Probably a dumb question, but: Why? |
Named functions are generally better as they'll have a name in any call stack errors. It also allows us to group the task definitions together at the bottom, and it's the gulp recommend approach. Lastly, ESlint will complain about undocumented functions, but it won't complain about undocumented anonymous functions. |
jimmynotjim
approved these changes
Jan 9, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Testing
gulp lintshould pass.Notes