Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build docker-compose functionality for easier set-up #257

Merged
merged 7 commits into from
Jul 26, 2022
Merged

Conversation

cooldragontattoo
Copy link
Contributor

@cooldragontattoo cooldragontattoo commented Jul 25, 2022

This PR includes the mechanics for using docker-compose to get the application up and running.

Aside from adding the Dockerfile and docker-compose.yaml, changes were made to the .Gemfile. I removed the requirements for json and uni-open, and added in a new gem for webrick (please see this similar GitHub issue for why I did that). Removing json and uni-open did not impair functionality and I am hoping that someone can clarify whether or not they are, indeed, required.

The reason they were removed is due to this error:

#10 3.745 [!] There was an error parsing Gemfile: No such file or directory @ rb_sysopen - https://pages.github.com/versions.json. Bundler cannot continue. #10 3.745 #10 3.745 # from /usr/src/app/Gemfile:6 #10 3.745 # ------------------------------------------- #10 3.745 # require 'open-uri' #10 3.745 > versions = JSON.parse(open('https://pages.github.com/versions.json').read) #10 3.745 # #10 3.745 # -------------------------------------------

It appears, based off of this intel, that there is an issue with jekyll and gem building inside a docker container due to environmental variable confusions. Please note, I did attempt numerous solutions that I stumbled across and none of them eradicated the error or constructed a functional container. Thus, I removed, and everything appears to be running smoothly.

Moreover, I re-wrote the instructions for the README.md. I am unsure if they are too vague/need to be more detailed? The reason I removed the previous ones is because they didn't work on my CFPB Mac.

Copy link
Member

@wpears wpears left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rad!

@wpears wpears merged commit f458a1f into master Jul 26, 2022
@wpears wpears deleted the make-dockerfile branch July 26, 2022 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants