Build docker-compose functionality for easier set-up #257
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes the mechanics for using docker-compose to get the application up and running.
Aside from adding the
Dockerfile
anddocker-compose.yaml
, changes were made to the.Gemfile
. I removed the requirements forjson
anduni-open
, and added in a new gem forwebrick
(please see this similar GitHub issue for why I did that). Removingjson
anduni-open
did not impair functionality and I am hoping that someone can clarify whether or not they are, indeed, required.The reason they were removed is due to this error:
#10 3.745 [!] There was an error parsing
Gemfile: No such file or directory @ rb_sysopen - https://pages.github.com/versions.json. Bundler cannot continue. #10 3.745 #10 3.745 # from /usr/src/app/Gemfile:6 #10 3.745 # ------------------------------------------- #10 3.745 # require 'open-uri' #10 3.745 > versions = JSON.parse(open('https://pages.github.com/versions.json').read) #10 3.745 # #10 3.745 # -------------------------------------------
It appears, based off of this intel, that there is an issue with jekyll and gem building inside a docker container due to environmental variable confusions. Please note, I did attempt numerous solutions that I stumbled across and none of them eradicated the error or constructed a functional container. Thus, I removed, and everything appears to be running smoothly.
Moreover, I re-wrote the instructions for the
README.md
. I am unsure if they are too vague/need to be more detailed? The reason I removed the previous ones is because they didn't work on my CFPB Mac.