Merge pull request #8571 from cfpb/ans_override_comms

Organize heading overrides comments
cfpb · Sep 12, 2024 · 456984c · 456984c
2 parents caeb234 + 38884bd
commit 456984c
Show file tree

Hide file tree

Showing 9 changed files with 11 additions and 2 deletions.
diff --git a/cfgov/unprocessed/apps/filing-instruction-guide/css/main.scss b/cfgov/unprocessed/apps/filing-instruction-guide/css/main.scss
@@ -22,6 +22,7 @@
 
   &:not(.m-info-unit__heading-text) > h4 {
     @include h3;
+    // Override for h3 margin.
     margin-top: 30px;
   }
 

diff --git a/cfgov/unprocessed/apps/paying-for-college/css/cf-enhancements.scss b/cfgov/unprocessed/apps/paying-for-college/css/cf-enhancements.scss
@@ -82,6 +82,7 @@
 
   &__text {
     @include h4;
+    // Override for h4 margin.
     margin: 0;
 
     .short-desc {

diff --git a/cfgov/unprocessed/apps/paying-for-college/css/college-costs/financial-item.scss b/cfgov/unprocessed/apps/paying-for-college/css/college-costs/financial-item.scss
@@ -42,6 +42,7 @@
     .financial-item__label > :not(p),
     .financial-item__value {
       @include heading-4;
+      // Override for h4 margin.
       margin-bottom: 0;
     }
   }

diff --git a/cfgov/unprocessed/apps/paying-for-college/css/disclosures.scss b/cfgov/unprocessed/apps/paying-for-college/css/disclosures.scss
@@ -158,6 +158,7 @@ $bp-graph-cols-min: 740px;
 
   &__prompt {
     @include heading-2;
+    // Override for h2 heading.
     margin-bottom: math.div(30px, $size-ii) + em;
   }
 
@@ -188,6 +189,7 @@ $bp-graph-cols-min: 740px;
   &__heading,
   &__label {
     @include heading-5;
+    // Override for h5 margin.
     margin-bottom: 0;
   }
 
@@ -1416,6 +1418,7 @@ $bp-graph-cols-min: 740px;
 
     &__summary-heading {
       @include heading-4;
+      // Override for h4 margin and text-transform.
       margin-bottom: math.div(10px, $size-iv) + em;
       text-transform: none;
     }

diff --git a/cfgov/unprocessed/apps/prepaid-agreements/css/main.scss b/cfgov/unprocessed/apps/prepaid-agreements/css/main.scss
@@ -27,6 +27,7 @@
     font-size: inherit;
 
     @include heading-4;
+    // Override for h4 margin.
     margin-bottom: math.div(math.div($grid-gutter-width, 6), $base-font-size-px) +
       em;
 
@@ -105,6 +106,7 @@
 .prepaid-agreements-detail {
   dt h2 {
     @include h4;
+    // Override for h4 margin.
     margin-bottom: math.div(math.div($grid-gutter-width, 6), $base-font-size-px) +
       em;
   }

diff --git a/cfgov/unprocessed/apps/regulations3k/css/reg-search.scss b/cfgov/unprocessed/apps/regulations3k/css/reg-search.scss
@@ -63,6 +63,7 @@
       }
       &__label {
         @include h4;
+        // Override for h4 margin.
         margin-bottom: 0;
       }
     }

diff --git a/cfgov/unprocessed/css/molecules/social-media.scss b/cfgov/unprocessed/css/molecules/social-media.scss
@@ -26,6 +26,7 @@
   &--share {
     .m-social-media__heading {
       @include heading-5;
+      // Override for h5 margin.
       margin: auto 0;
     }
 

diff --git a/cfgov/unprocessed/css/organisms/post-preview.scss b/cfgov/unprocessed/css/organisms/post-preview.scss
@@ -77,7 +77,6 @@
   &__subtitle {
     @include heading-6;
 
-    // margin-top: math.div(math.div($grid-gutter-width, 2), $base-font-size-px) + em;
     clear: both;
   }
 

diff --git a/cfgov/unprocessed/css/organisms/secondary-nav.scss b/cfgov/unprocessed/css/organisms/secondary-nav.scss
@@ -160,7 +160,7 @@
 
     &--parent {
       @include heading-4;
-
+      // Override for h4 margin.
       margin-bottom: inherit;
     }
   }