Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Organize heading overrides comments #8571

Merged
merged 1 commit into from
Sep 12, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@

&:not(.m-info-unit__heading-text) > h4 {
@include h3;
// Override for h3 margin.
margin-top: 30px;
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -82,6 +82,7 @@

&__text {
@include h4;
// Override for h4 margin.
margin: 0;

.short-desc {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,7 @@
.financial-item__label > :not(p),
.financial-item__value {
@include heading-4;
// Override for h4 margin.
margin-bottom: 0;
}
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -158,6 +158,7 @@ $bp-graph-cols-min: 740px;

&__prompt {
@include heading-2;
// Override for h2 heading.
margin-bottom: math.div(30px, $size-ii) + em;
}

Expand Down Expand Up @@ -188,6 +189,7 @@ $bp-graph-cols-min: 740px;
&__heading,
&__label {
@include heading-5;
// Override for h5 margin.
margin-bottom: 0;
}

Expand Down Expand Up @@ -1416,6 +1418,7 @@ $bp-graph-cols-min: 740px;

&__summary-heading {
@include heading-4;
// Override for h4 margin and text-transform.
margin-bottom: math.div(10px, $size-iv) + em;
text-transform: none;
}
Expand Down
2 changes: 2 additions & 0 deletions cfgov/unprocessed/apps/prepaid-agreements/css/main.scss
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@
font-size: inherit;

@include heading-4;
// Override for h4 margin.
margin-bottom: math.div(math.div($grid-gutter-width, 6), $base-font-size-px) +
em;

Expand Down Expand Up @@ -105,6 +106,7 @@
.prepaid-agreements-detail {
dt h2 {
@include h4;
// Override for h4 margin.
margin-bottom: math.div(math.div($grid-gutter-width, 6), $base-font-size-px) +
em;
}
Expand Down
1 change: 1 addition & 0 deletions cfgov/unprocessed/apps/regulations3k/css/reg-search.scss
Original file line number Diff line number Diff line change
Expand Up @@ -63,6 +63,7 @@
}
&__label {
@include h4;
// Override for h4 margin.
margin-bottom: 0;
}
}
Expand Down
1 change: 1 addition & 0 deletions cfgov/unprocessed/css/molecules/social-media.scss
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@
&--share {
.m-social-media__heading {
@include heading-5;
// Override for h5 margin.
margin: auto 0;
}

Expand Down
1 change: 0 additions & 1 deletion cfgov/unprocessed/css/organisms/post-preview.scss
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,6 @@
&__subtitle {
@include heading-6;

// margin-top: math.div(math.div($grid-gutter-width, 2), $base-font-size-px) + em;
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This existed commented out back to the Less, so seems like it can be removed.

clear: both;
}

Expand Down
2 changes: 1 addition & 1 deletion cfgov/unprocessed/css/organisms/secondary-nav.scss
Original file line number Diff line number Diff line change
Expand Up @@ -160,7 +160,7 @@

&--parent {
@include heading-4;

// Override for h4 margin.
margin-bottom: inherit;
}
}
Expand Down
Loading