Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove regs label margin #8577

Merged
merged 1 commit into from
Sep 13, 2024
Merged

Remove regs label margin #8577

merged 1 commit into from
Sep 13, 2024

Conversation

anselmbradford
Copy link
Member

@anselmbradford anselmbradford commented Sep 13, 2024

Expandables already format labels as h4s, so the @include h4; was redundant, other than it added margin at mobile. However, with the margin added it was misaligning the label text and the cue, since the margin was only added to the label. Probably best to just strip out this customization and make the label slightly closer to its content, which matches the desktop appearance.

Changes

  • Moves all expandable overriding code together and adds a TODO.
  • Change nth-child(3n) to last-child() to remove last border of filters.
  • Removes expandable label h4 customization.

How to test this PR

  1. yarn build
  2. Visit http://localhost:8000/rules-policy/regulations/search-regulations/results/?regs=1002&q=mortgage
  3. Resize to mobile and compare the filters labels position to production. It should be slightly closer to the content.

Screenshots

Before:

Screenshot 2024-09-13 at 1 05 55 PM

After:
Screenshot 2024-09-13 at 1 06 09 PM

@anselmbradford anselmbradford added this pull request to the merge queue Sep 13, 2024
Merged via the queue into main with commit 1de9b7c Sep 13, 2024
11 checks passed
@anselmbradford anselmbradford deleted the ans_regs_margin branch September 13, 2024 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants