-
Notifications
You must be signed in to change notification settings - Fork 71
Updates to hero graphic guidelines #461
Comments
I've been working on tackling all the tasks in this user story as part of a full update of the hero page. This update can be MVP and we can continue to make adjustments moving forward. My primary goals at this point are to:
At this point I'm looking for a review from a few perspectives:
Some questions to answer/address:
@huetingj
Here's a link to the page: http://nataliafitzgerald.github.io/design-manual/global-elements/heroes.html If anyone would like to jump on Hangouts to discuss any of the specifics I've mentioned above I'm eager to push forward on this so I would be appreciative. Or, feel free to comment here. I'd like to get this MVP up as soon as possible so if I don't hear from people I'll start reaching out to others. |
I spoke to @kurzn on Mattermost today. Here were some of her recommendations:
@jordanafyne has offered to take a look tomorrow morning and we will talk through any recommendations she has. |
Overall looks really good and I appreciate how much detail you've included for situations like two line headings and the clear space between the text and photo content for the overlay version.
|
Reviewing now. Rather than post one giganto-comment, I think I'll do it piece-by-piece. First: Should the "Content guidelines" section include any explanation of the difference between a one-line heading and a two-line heading? It may not be totally self-evident.
|
|
|
OK, I would suggest adding some copy to make those first two points clear. We could have two heading input fields, but the Hero module is already insanely complex to handle all of the different stylistic options, so I hesitate to make it more complex. I guess we can cross that bridge if we ever get to experimenting with back-end character limiting. |
I agree that the "standard" (or most common, at least) style, the no-bleed illustration, should come first, and I agree with the suggestion to add some language about when to choose other styles. |
@Scotchester - As part of our Platform team work @ielerol will be working on improving the experience and guidance for users within Wagtail so perhaps we can take a closer look at the complexity within this module. And, we will consider this when we (hopefully) visit the backend validation approach. |
Oh please let's never do this. It'd probably be better to check the length of the title field and update the text field max characters with some JS than to provide users duplicate fields. |
That doesn't work if there's a manual break in the heading, though, as the two-line example on Natalia's page show. |
That would be a |
This looks great, and I think having character counts defined for the content is valuable.
|
@jimmynotjim @Scotchester |
|
Image sizing
|
Whoops, forgot one for image sizing:
|
Text styling901px and above
601–900
Accessibility
|
Hey this is looking good @nataliafitzgerald the only thing I think we should reconsider is the limits on the amount of content in the "Two line heading" heros subheading. I understand it is done to try and keep the heros a consistent height at desktop but I feel like the current suggested limits in this screen shot are too restrictive for our content needs. I'd strongly recommend we instead have the same maximum character count of 185 for both subheadings... One line heading
Two line heading
Other question |
Thanks for your feedback! My goal with this next release is not to change what we've been doing but to document it with more detail. For example, our existing hero standards state that the heading should be "25 characters maximum, including spaces" and subheadings should be "185 characters including spaces." What this means is that as far as our existing guidelines (and Wagtail helper text) are concerned, the two line heading isn't even possible. Additionally our existing guidelines include no mention of bleeding heroes, photo heroes, sizing for images, etc. My goal at this point is to get the DM up to speed so that we all know what it currently possible and how to accomplish it. Yes, maintaining a consistent height for heroes is important to the visual hierarchy (and is one of the goals of having max character counts). But, an equally important factor that goes into the character counts is to ensure that hero content serves to introduce and orient a user in a concise way without overwhelming them with a lot of text right out of the gate. Since our web pages are incredibly text heavy heroes serve an important role; a respectful resting point where a user can determine whether this is a page that they want (or dare to) to dive deeper into. Up until this point, our main struggle has been with users exceeding the 185 max character count with subheading text in one-line heroes. Two line headings are actually not at all common on our site, there are currently only two live examples, Planning for Retirement and Owning a Home. On both of these, there is a forced break in the heading to separate the product name from a description. I suspect that this has something to do with users not knowing what product names mean (something that's been flagged a lot over the years). In terms of the minimums in general, they were inspired by our work on Consumer Credit Trends where the content was cut in such a way that the content strategy goals and design goals of the hero graphic were no longer being met (recapping for the benefit of others). After that experience, @marteki and I realized that it would be helpful to document minimums so that content writers are clear with where they will want their content to be, when they don't have the luxury of testing things out in Wagtail like we do. In terms of the 25 character minimum for subheadings under a 2-line heading, I was trying to establish the point where anything less would create an imbalance between heading and subheading. There wasn't a specific use case so if you have any recommendations as to what that minimum count could be, let me know. |
@jimmynotjim @Scotchester |
@ajbush I'll consult with @jordanafyne today to see what she thinks would be most useful for our content writers/templates. |
That sounds good to me. We definitely need to get better at pushing incremental changes rather than holding up a change to be absolutely perfect. |
@ajbush @jordanafyne Our grid changed recently (just a change to match our intended grid) so some of the counts were off because of that. I think what was happening with that 25 character count for the subheading after a two line heading was actually a typo. The 1 was missing at the beginning (125). Thanks for catching that! Based on this experiment, I've made some tweaks: Heading
Subheading
@jordanafyne - Could you take a look at this Wagtail mock-up next week and make sure the counts look correct? Do you know of a more fail safe, precise way to test this? |
@nataliafitzgerald I got very slightly different counts, which, as guidelines, I don't think matters very much, but if these numbers are going to be input into a Wagtail character counter plugin, then it may make a difference. Should probably set that hard limit at the lower number, if choosing between the two. That Build demo is great -- I hope you're able to incorporate those images into the documentation. Heading One-line heading: 41 characters maximum Subheading Subheading after one-line heading: Between 168 and 198 characters |
@jordanafyne |
@Scotchester @kurzn Also, @huetingj - Can we meet in the next couple of days to talk through the page? |
@jimmynotjim @kurzn I'll probably also open an issue so that we can start talking about the sections of the page, specifically "Global patterns" which seems to mostly contain page types and "Page components" which could be renamed "UI elements" or "UI components." |
We discussed this in a meeting, but I'm documenting here for the record that the original plan with the IA was that within global elements there would be a "page intros" subsection that contained heroes, text introductions and item introductions, since every page should have one of those. Also, as a team we need to do some more explicit thinking around when a landing or sub-landing page should have a hero vs. a text introduction, which we ultimately want to document on this page. But that shouldn't hold up the work Natalia has already done. |
I brought this up in chat, but is there a reason not to organize the DM by atomic type to keep the language consistent? That was the main reasons we decided to use Atomic Design to begin with, but it seems we're holding out within the DM itself. |
I shared the hero page in my Platform team ("Remember the humans") meeting and got some valuable feedback. Thank you @ielerol!
I also met with @huetingj to go over the full page, doing a deeper dive into the "Style" section which is really graphic designer focused. She felt that this is a good step in the right direction. As she works through hero graphics as part of her project work we may learn more about what we'd like to think about stylistically and practically as we build photo heroes. |
I shared this in my Design Working Session and received some additional feedback. Next, I'll map out what I'll tackle as part of this initial release and what I'll line up for the next release. Here's the feedback I received:
@marteki @Dnpizarro @huetingj - Let me know if I missed anything. |
Remaining tasksThis week's release
Next release
If anyone has anything to add that isn't captured in this list or reflected on the page, let me know or post below. I have pushed some additional updates live this evening: https://nataliafitzgerald.github.io/design-manual/global-elements/heroes.html |
@nataliafitzgerald here is some Use Case language. Happy to tweak as needed! I'm also working on the updates to the 'no links in hero' language we talked about. Use Case WHEN TO USE WHEN OTHER OPTIONS ARE BETTER |
Ok, I added your proposed updates @sarahsimpson09. Here's the updated page: https://nataliafitzgerald.github.io/design-manual/global-elements/heroes.html |
Could be good to add examples of good headings/subheadings used in existing heroes as well. Something to consider down the line. |
@kurzn |
Should we add print rules for future work as well or should that go in it's own "we need to update everything for print" issue? |
@jimmynotjim Did you mean to post that in a data viz issue? Or are you talking about how a hero prints if someone prints a page that has one? |
The later |
Manual The documentation in the Design Manual has been updated to include additional guidelines for heros. This change includes updated rules about image sizes and spacing. The changes to Capital Framework include an attempt to simplify the markup and offer additional image sizes through inline styles. cfpb/design-manual#461
Manual The documentation in the Design Manual has been updated to include additional guidelines for heros. This change includes updated rules about image sizes and spacing. The changes to Capital Framework include an attempt to simplify the markup and offer additional image sizes through inline styles. cfpb/design-manual#461
Manual The documentation in the Design Manual has been updated to include additional guidelines for heros. This change includes updated rules about image sizes and spacing. The changes to Capital Framework include an attempt to simplify the markup and offer additional image sizes through inline styles. cfpb/design-manual#461
Manual The documentation in the Design Manual has been updated to include additional guidelines for heros. This change includes updated rules about image sizes and spacing. The changes to Capital Framework include an attempt to simplify the markup and offer additional image sizes through inline styles. cfpb/design-manual#461
Manual The documentation in the Design Manual has been updated to include additional guidelines for heros. This change includes updated rules about image sizes and spacing. The changes to Capital Framework include an attempt to simplify the markup and offer additional image sizes through inline styles. cfpb/design-manual#461
The documentation in the Design Manual has been updated to include additional guidelines for heros. This change includes updated rules about image sizes and spacing. The changes to Capital Framework include an attempt to simplify the markup and offer additional image sizes through inline styles. cfpb/design-manual#461
User story
As a Designer/Developer/Content person, I want the hero guidelines to be useful and up-to-date so that I can know my options and successfully implement the pattern.
Acceptance criteria
Discussion (optional)
Related tasks:
The text was updated successfully, but these errors were encountered: