Skip to content
This repository has been archived by the owner on Jul 10, 2020. It is now read-only.

Complete the removal of Georgia #510

Merged
merged 3 commits into from
Aug 16, 2017
Merged

Complete the removal of Georgia #510

merged 3 commits into from
Aug 16, 2017

Conversation

nataliafitzgerald
Copy link
Contributor

@nataliafitzgerald nataliafitzgerald commented Aug 15, 2017

This pull request is related to these issues:

Remove Georgia from Design Manual
#499

Defining the use of Avenir Next vs. Georgia
#347 (comment)

In January of 2017 we decided that Avenir Next would be the default font site-wide. It appears that we may have started to move forward with this change but did not complete it. From what I can tell, we've stopped using Georgia for body copy on DM pages. But there are instances of images on the Typography page that still include Georgia. Georgia is also still included in the type hierarchy (although the supporting visual is in Avenir Next). This pull request aims to complete the removal of Georgia from the Design Manual (with the exception of some static images contained on the page that will need to be updated at a later date).

Additions

Removals

  • All instances of Georgia in the HTML code

Changes

  • Color names updated to current color palette naming system

Testing

Review

Preview this PR without the whitespace changes

Screenshots

Notes

Todos

Checklist

  • Changes are limited to a single goal (no scope creep)
  • Code can be automatically merged (no conflicts)
  • Code follows the standards laid out in the front end playbook
  • Passes all existing automated tests
  • New functions include new tests
  • New functions are documented (with a description, list of inputs, and expected output)
  • Placeholder code is flagged
  • Visually tested in supported browsers and devices
  • Project documentation has been updated (including the "Unreleased" section of the CHANGELOG)

This pull request is related to these issues: 

Remove Georgia from Design Manual
#499

Defining the use of Avenir Next vs. Georgia 
#347 (comment)
Copy link
Member

@caheberer caheberer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we should be more specific about italics? Looking at our content guidelines, titles of publications are the only instance where italics should be used. I'm not certain, but it sounded like even that might be removed.

@nataliafitzgerald
Copy link
Contributor Author

@caheberer
Good point. I actually don't know of any instances in our editorial guidelines where we specify that italics should be used. @kurzn - Can you consult?

@kurzn
Copy link
Contributor

kurzn commented Aug 16, 2017

@nataliafitzgerald @caheberer yes that is an error in the guidelines re: publications. Working to have that fixed in the version that's circulating for approval.

@nataliafitzgerald
Copy link
Contributor Author

Ok, sounds good. @caheberer - Can you take one more look at the latest commit and we can merge this?

@Scotchester
Copy link
Contributor

Just to clarify: We're talking about our "publications", right? I would hope we'd still use italics to set off the titles of published works (books, movies, magazines, etc.), if we ever had a need to refer to them.

@kurzn
Copy link
Contributor

kurzn commented Aug 16, 2017

@Scotchester Nope. AP doesn't use italics. Book titles are in quotation marks.

@cfarm cfarm merged commit d8a3e21 into gh-pages Aug 16, 2017
@Scotchester
Copy link
Contributor

Ugh, AP. So good sometimes, so dumb other times.

@nataliafitzgerald nataliafitzgerald deleted the nataliafitzgerald-patch-1 branch August 16, 2017 15:48
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants