Skip to content

Commit

Permalink
Merge pull request #2128 from cfpb/ans_left_fcm
Browse files Browse the repository at this point in the history
Remove `o-featured-content-module--left`
  • Loading branch information
anselmbradford authored Nov 26, 2024
2 parents a688ab9 + c12548f commit 96966e5
Show file tree
Hide file tree
Showing 18 changed files with 21 additions and 69 deletions.
26 changes: 0 additions & 26 deletions docs/pages/featured-content-modules.md
Original file line number Diff line number Diff line change
Expand Up @@ -98,32 +98,6 @@ variation_groups:
the image area. Make sure the subject of the thumbnail photo is not
awkwardly obscured by the play button.
variation_name: Visual anchored on the right (default)
- variation_code_snippet: >-
<section class="o-featured-content-module
o-featured-content-module--left">
<div class="o-featured-content-module__text">
<h2>Featured content</h2>
<p>
Lorem ipsum dolor sit amet, ei ius adhuc inani iudico, labitur
instructior ex pri. Cu pri inani constituto, cum aeque noster
commodo cu.
</p>
<a class="a-link
a-link--jump">
<span class="a-link__text">Read more about the feature</span>
</a>
</div>
<div class="o-featured-content-module__visual">
<img class="o-featured-content-module__img"
src="https://dummyimage.com/1076x606/addc91/101820"
alt="">
</div>
</section>
variation_description: >-
Adding the `o-featured-content-module--left` modifier places the
visual to the left of the text and doesn't include a background
color or border.
variation_name: Left-anchored visual
variation_group_name: Variations
variation_group_description: >-
The modifiers below describe how to change where the featured content
Expand Down

Large diffs are not rendered by default.

Large diffs are not rendered by default.

Large diffs are not rendered by default.

Large diffs are not rendered by default.

Large diffs are not rendered by default.

Large diffs are not rendered by default.

Large diffs are not rendered by default.

Large diffs are not rendered by default.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion packages/cfpb-design-system/dist/index.css

Large diffs are not rendered by default.

4 changes: 2 additions & 2 deletions packages/cfpb-design-system/dist/index.css.map

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion packages/cfpb-design-system/dist/index.js.map

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion packages/cfpb-design-system/dist/utilities/index.css

Large diffs are not rendered by default.

4 changes: 2 additions & 2 deletions packages/cfpb-design-system/dist/utilities/index.css.map

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion packages/cfpb-design-system/dist/utilities/index.js.map

Large diffs are not rendered by default.

Original file line number Diff line number Diff line change
Expand Up @@ -70,26 +70,4 @@
transform: translateX(-50%);
}
}

// Modifiers
&--left {
/* Left modifier doesn't have a border/background. If in the future we
have a left arranged FCM we'll want to make the border/background
its own modifer */
border: initial;
background-color: initial;

.o-featured-content-module__visual {
left: 0;
right: initial;
}

.o-featured-content-module__text {
// Tablet and above.
@include respond-to-min($bp-sm-min) {
padding-left: $fcm-visual-width + $grid-gutter-width;
padding-right: math.div($grid-gutter-width, $base-font-size-px) + em;
}
}
}
}

0 comments on commit 96966e5

Please sign in to comment.