Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refine button links - add icon examples #2106

Merged
merged 1 commit into from
Nov 13, 2024
Merged

Refine button links - add icon examples #2106

merged 1 commit into from
Nov 13, 2024

Conversation

anselmbradford
Copy link
Member

@anselmbradford anselmbradford commented Nov 12, 2024

<button> and <a> tags can both use a-btn classes. This allows making a link that looks like a button and vice versa.

Changes

  • Add button link examples that have icons.
  • Properly position underline in links with icons that are using a-btn classes.
  • Refactor button link SCSS to use mixin.

Testing

  1. Visit button and links pages in the PR previews and see the button link and destructive link
    https://deploy-preview-2106--cfpb-design-system.netlify.app/design-system/components/buttons
    https://deploy-preview-2106--cfpb-design-system.netlify.app/design-system/components/links

Screenshots

Screenshot 2024-11-12 at 4 44 44 PM

Copy link

netlify bot commented Nov 12, 2024

Thanks for the improvements! Browse a preview of your changes using the link below.

Name Link
🔨 Latest commit 5edc8e5
🔍 Latest deploy log https://app.netlify.com/sites/cfpb-design-system/deploys/6733cba1c6b21600088dbb01
😎 Deploy Preview https://deploy-preview-2106--cfpb-design-system.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@anselmbradford anselmbradford force-pushed the ans_link_btns branch 2 times, most recently from 7033a58 to 1093c08 Compare November 12, 2024 21:38
@anselmbradford anselmbradford merged commit b907a72 into main Nov 13, 2024
8 checks passed
@anselmbradford anselmbradford deleted the ans_link_btns branch November 13, 2024 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

3 participants