Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add text-free icon button examples #2108

Merged
merged 1 commit into from
Nov 13, 2024
Merged

Conversation

anselmbradford
Copy link
Member

@anselmbradford anselmbradford commented Nov 13, 2024

Some buttons only have an icon and no text. Add examples for these.

Changes

  • Add text-free icon button examples

Testing

  1. Button preview should show icon-only buttons https://deploy-preview-2108--cfpb-design-system.netlify.app/design-system/components/buttons

Screenshots

Screenshot 2024-11-13 at 1 09 06 PM

Copy link

@accesslint accesslint bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are accessibility issues in these changes.

docs/pages/buttons.md Outdated Show resolved Hide resolved
docs/pages/buttons.md Outdated Show resolved Hide resolved
Copy link

netlify bot commented Nov 13, 2024

Thanks for the improvements! Browse a preview of your changes using the link below.

Name Link
🔨 Latest commit 8527b37
🔍 Latest deploy log https://app.netlify.com/sites/cfpb-design-system/deploys/6734ed5c2ff0300008b98072
😎 Deploy Preview https://deploy-preview-2108--cfpb-design-system.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

@accesslint accesslint bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏 You fixed the issue(s)! Great work.

@anselmbradford anselmbradford merged commit dded2b4 into main Nov 13, 2024
8 checks passed
@anselmbradford anselmbradford deleted the ans_icon_btn_no_txt branch November 13, 2024 19:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

2 participants