Provide icon exports #2137
Merged
Provide icon exports #2137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Thanks for the improvements! Browse a preview of your changes using the link below.
To edit notification comments on pull requests, go to your Netlify site configuration. |
anselmbradford
approved these changes
Dec 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One piece of fallout from 005bce9 is that the way code is imported by dependent js is actually quite different. With an
exportskey provided, only those exports are allowed rather than falling back to walking the filesystem (which we do a bunch in cf.gov).This provides an
iconsexport so that icons can be imported into js (which will need to be updated in dependent projects, namely cfgov, from existing@cfpb/cfpb-design-system/src/components/cfpb-icons/icons/<icon.svg>style imports. I'll do this for cfgov once this PR is merged and a release created (along with changes to js imports which 005bce9 also requires).