IRS returns incorrect values in smoke tests

[schbetsy]

In this screenshot, the IRS shows 92 total LARs for this submission, but the actual submission only has 10 LARs. I've seen this frequently when uploading multiple files for an institution.

[schbetsy]

Here's the steps for one way I have generated this bug. Notes: I was using institution 6999998 for all submissions. HMDA_IS_DEMO was set to true.

1. Clean slate in Postgres: in psql hmda, drop table lars cascade;, \q
2. Start the API in the usual way: In sbt, clean, compile, project api, reStart (repeat reStop-reStart cycle as necessary until the demo data gets populated 😞 )
3. Create submission. upload 90-line file. check irs... total lars = 90. ✅
4. Create another submission. upload 400-line file. check irs... total lars = 490. ❌
5. Just for fun, do it again: upload 10-line file. irs says total lines = 500. ❌

I've also seen it when running the whole docker setup.

[nickgrippin]

Confirmed, the issue seems to be an intermittent failure to delete the previous LAR submissions from the repository, affecting the IRS report and modified LAR endpoint.

[nickgrippin]

IRS reporting incorrect values will be addressed in #984

This ticket will stay open in order to address the bug with the modified LAR endpoint.

[schbetsy]

This seems to be resolved by #1000.

[nickgrippin]

I agree, that's what I'm seeing as well. Closing this ticket.