Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move IRS to Actor model #1000

Merged
merged 4 commits into from
Jun 8, 2017
Merged

Move IRS to Actor model #1000

merged 4 commits into from
Jun 8, 2017

Conversation

nickgrippin
Copy link

Closes #984

@nickgrippin
Copy link
Author

Millennium PR!

💯0

@codecov-io
Copy link

codecov-io commented Jun 7, 2017

Codecov Report

Merging #1000 into master will increase coverage by 0.06%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1000      +/-   ##
==========================================
+ Coverage   93.27%   93.33%   +0.06%     
==========================================
  Files         287      287              
  Lines        3701     3677      -24     
  Branches       67       72       +5     
==========================================
- Hits         3452     3432      -20     
+ Misses        249      245       -4
Impacted Files Coverage Δ
...hmda/query/repository/filing/FilingComponent.scala 95.28% <ø> (+0.04%) ⬆️
...ry/projections/filing/HmdaFilingDBProjection.scala 100% <ø> (ø) ⬆️
api/src/main/scala/hmda/api/HmdaPlatform.scala 0% <ø> (ø) ⬆️
census/src/main/scala/hmda/census/model/Msa.scala 100% <100%> (ø)
.../institutions/submissions/SubmissionIrsPaths.scala 100% <100%> (ø) ⬆️
...pi/src/main/scala/hmda/api/model/IrsResponse.scala 100% <100%> (ø) ⬆️
...c/main/scala/hmda/validation/ValidationStats.scala 100% <100%> (ø) ⬆️
...ain/scala/hmda/validation/SubmissionLarStats.scala 100% <100%> (ø) ⬆️
...mda/persistence/processing/HmdaFileValidator.scala 98.55% <100%> (+0.02%) ⬆️
...ala/hmda/api/protocol/processing/MsaProtocol.scala 93.75% <100%> (ø) ⬆️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c7481a1...06c22b3. Read the comment docs.

@nickgrippin
Copy link
Author

I'm not seeing the #979 error occur on this branch. Can someone else test/confirm this?

To clarify: when viewing the Postgres lars table, I can see the correct count of lars after every file upload event.

case class MsaMap(
msas: ListMap[String, Msa] = ListMap[String, Msa]()
) {
def +(lar: LoanApplicationRegister): MsaMap = {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How many LAR records do we usually see here? ListMap is a collection that is only suitable for small number of records. Do you need the extra properties of a ListMap or would an immutable Map be sufficient?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the IRS, since the rows are by MSA/MD (plus a total row), there should be no more than 1000 rows. Not sure if that is considered small.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My original concern was related to ordering and pagination. Before I switched to storing a Seq in the ValidationStats, I was worried about relying on the consistency of the iteration order through a Map. ListMap guarantees a sorted order based on insertion, but that property is no longer necessary. I'll make the switch back to an immutable Map.

@jmarin jmarin merged commit b162ef6 into cfpb:master Jun 8, 2017
@schbetsy
Copy link
Contributor

schbetsy commented Jun 8, 2017

@nickgrippin I'll check on #979 and try to confirm that it's fixed with this update.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants