2023 support and 2024 edits #4705
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 8 commits
October 6, 2023 14:20
…unit test for V660 to reflect new credit scoring model enums
lchen-2101
reviewed
Oct 12, 2023
lchen-2101
reviewed
Oct 16, 2023
| ReferWithCaution, | ||
| UnableToDetermineOrUnknown | ||
| } | ||
| import hmda.model.filing.lar.enums.{Accept, ApproveEligible, ApproveIneligible, Caution, Eligible, EmptyAUSResultValue, Error, Incomplete, Ineligible, Invalid, OtherAUS, OtherAutomatedUnderwritingResult, OutOfScope, Refer, ReferEligilbe, ReferIneligible, ReferWithCaution, UnableToDetermineOrUnknown} |
There was a problem hiding this comment.
one long line seems like it would be kind of hard to read, or should we just do ._?
lchen-2101
reviewed
Oct 16, 2023
added 3 commits
October 18, 2023 07:08
…new credit scoring model edits
…new credit scoring model edits
…new credit scoring model edits
PatrickGoRaft
changed the title
PatrickGoRaft
commented
Oct 23, 2023
hmda/src/main/scala/hmda/api/http/filing/submissions/ParseErrorHttpApi.scala
Show resolved
Hide resolved
PatrickGoRaft
commented
Oct 23, 2023
lchen-2101
reviewed
Oct 23, 2023
common/src/main/scala/hmda/model/filing/ParserValidValuesLookup.scala
Outdated
Show resolved
Hide resolved
This was referenced Nov 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #4701
closes #4699
closes #4700
closes #4702