Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add validation to LEI in data browser #4826

Merged
merged 3 commits into from
Jun 20, 2024
Merged

add validation to LEI in data browser #4826

merged 3 commits into from
Jun 20, 2024

Conversation

kgudel
Copy link
Contributor

@kgudel kgudel commented Jun 12, 2024

Closes #4825

jaredb96
jaredb96 approved these changes Jun 12, 2024
View reviewed changes
Copy link
Contributor

@jaredb96 jaredb96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

PatrickGoRaft
PatrickGoRaft requested changes Jun 13, 2024
View reviewed changes
Copy link
Contributor

@PatrickGoRaft PatrickGoRaft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could move this logic to our HMDAMessageFilter object

https://github.com/cfpb/hmda-platform/blob/master/common/src/main/scala/hmda/messages/HmdaMessageFilter.scala

and we can probably simplify this with the LEI regex already defined in this chunk of code.

https://github.com/cfpb/hmda-platform/blob/master/common/src/main/scala/hmda/messages/HmdaMessageFilter.scala#L19-L22

@PatrickGoRaft
Copy link
Contributor

LGTM

@PatrickGoRaft PatrickGoRaft merged commit 4c3b3ae into cfpb:master Jun 20, 2024
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PatrickGoRaft PatrickGoRaft PatrickGoRaft requested changes

@jaredb96 jaredb96 jaredb96 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Validate LEI Format in Data-Browser
3 participants
@kgudel @PatrickGoRaft @jaredb96