Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix DataGenerator unit test. #4848

Merged
merged 4 commits into from
Jul 23, 2024
Merged

Fix DataGenerator unit test. #4848

merged 4 commits into from
Jul 23, 2024

Conversation

jaredb96
Copy link
Contributor

Resolves #4847

@jaredb96 jaredb96 self-assigned this Jul 11, 2024
@jaredb96 jaredb96 marked this pull request as ready for review July 12, 2024 15:55
tptignor
tptignor approved these changes Jul 12, 2024
View reviewed changes
Copy link
Contributor

@tptignor tptignor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM pending the tests passing in actions

@jaredb96
Copy link
Contributor Author

LGTM pending the tests passing in actions

Just so we're on the same page, it's going to fail here until your fixes are in

@kgudel kgudel merged commit 90b7fd3 into cfpb:master Jul 23, 2024
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tptignor tptignor tptignor approved these changes

@PatrickGoRaft PatrickGoRaft Awaiting requested review from PatrickGoRaft

Assignees

@jaredb96 jaredb96

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix failing Data Publisher Unit Tests
3 participants
@jaredb96 @tptignor @kgudel