Remove unnecessary TreeIndexView media property #13
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The TreeModelAdmin index view (TreeIndexView) defines its own
media
property, which pulls in the extra CSS from this package. This is unnecessary, because the base ModelAdmin IndexView from which it inherits already provides amedia
property, which pulls in both extra CSS and JS, if specified by inheriting ModelAdmins.This functionality exists in all versions of Wagtail supported by this package: 1.13, 2.5, and current master.
Removing this not only eliminates duplicate code, but also fixes a problem where TreeModelAdmins can't provide their own JS files, because they aren't included in the
media
property. For example, TreeModelAdmin currently isn't compatible with wagtail-orderable for this reason. Making this change, and falling back on the default CSS+JS inclusion, allows for customization of TreeModelAdmin JS.Checklist