Remove unnecessary TreeIndexView media property #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
willbarton
approved these changes
Jan 8, 2020
The TreeModelAdmin index view (TreeIndexView) defines its own media property, which pulls in the extra CSS from this package. This is unnecessary, because the base ModelAdmin IndexView from which it inherits already provides a media property, which pulls in both extra CSS and JS, if specified by inheriting ModelAdmins. This functionality exists in all versions of Wagtail supported by this package: 1.13: https://github.com/wagtail/wagtail/blob/v1.13/wagtail/contrib/modeladmin/views.py#L251-L256 2.5: https://github.com/wagtail/wagtail/blob/v2.5/wagtail/contrib/modeladmin/views.py#L261-L266 Current master: https://github.com/wagtail/wagtail/blob/7fdb06c86cd7fd32e4ff6b85e012daffbe1637e4/wagtail/contrib/modeladmin/views.py#L258-L262 Removing this not only eliminates duplicate code, but also fixes a problem where TreeModelAdmins can't provide their own JS files, because they aren't included in the media property. For example, TreeModelAdmin currently isn't compatible with wagtail-orderable (https://pypi.org/project/wagtail-orderable/) for this reason. Making this change, and falling back on the default CSS+JS inclusion, allows for customization of TreeModelAdmin JS.
chosak
force-pushed
the
remove-indexview-media
branch
from
6106687
to
6408d95
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The TreeModelAdmin index view (TreeIndexView) defines its own
mediaproperty, which pulls in the extra CSS from this package. This is unnecessary, because the base ModelAdmin IndexView from which it inherits already provides amediaproperty, which pulls in both extra CSS and JS, if specified by inheriting ModelAdmins.This functionality exists in all versions of Wagtail supported by this package: 1.13, 2.5, and current master.
Removing this not only eliminates duplicate code, but also fixes a problem where TreeModelAdmins can't provide their own JS files, because they aren't included in the
mediaproperty. For example, TreeModelAdmin currently isn't compatible with wagtail-orderable for this reason. Making this change, and falling back on the default CSS+JS inclusion, allows for customization of TreeModelAdmin JS.Checklist