-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove the Django requirement from this application #17
Conversation
We should probably only pin Wagtail in this application, and support the version range for Django that our Wagtail version specifies.
Wagtail 2.9 was released today, Do we want to start thinking about heading right to that instead of 2.8? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is way too broad a removal of Django. We still need to test against Django 1.11 and 2.2 (we could drop testing against 2.0).
We just do not need to specify a required version in setup.py for pip to resolve dependencies. For that we can take whatever the version of Wagtail we're using provides.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is way too broad a removal of Django. We still need to test against Django 1.11 and 2.2 (we could drop testing against 2.0).
We just do not need to specify a required version in setup.py for pip to resolve dependencies. For that we can take whatever the version of Wagtail we're using provides.
We should probably only pin Wagtail in this application, and support
the version range for Django that our Wagtail version specifies.