Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Wagtail 2.11 release #24

Merged
merged 3 commits into from
Nov 30, 2020
Merged

Support for Wagtail 2.11 release #24

merged 3 commits into from
Nov 30, 2020

Conversation

Stormheg
Copy link
Contributor

@Stormheg Stormheg commented Nov 28, 2020

Hi 👋

This PR adds support for the latest Wagtail 2.11 release.

A new 1.4.0 1.3.0 release of this package should be made to PyPi.

@Stormheg
Copy link
Contributor Author

Regarding the failing CI:

coveralls.exception.CoverallsException: Running on Github Actions but GITHUB_TOKEN is not set. Add "env: GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}" to your step config.

Looks like Coveralls now expects to be passed GITHUB_TOKEN. I'll try adding that and see if that works...

Unittest job fails due to missing GITHUB_TOKEN
@Stormheg
Copy link
Contributor Author

That didn't work...

coveralls.exception.CoverallsException: Could not submit coverage: 500 Server Error: Internal Server Error for url: https://coveralls.io/api/v1/jobs

@willbarton
Copy link
Member

@Stormheg I'm trying to see what might be going on with Coveralls here.

@coveralls
Copy link

coveralls commented Nov 30, 2020

Pull Request Test Coverage Report for Build 391900251

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%

Totals Coverage Status
Change from base Build 232896458: 0.0%
Covered Lines: 202
Relevant Lines: 202

💛 - Coveralls

@Stormheg
Copy link
Contributor Author

@willbarton thanks, coveralls is working now!

@willbarton
Copy link
Member

Thanks, @Stormheg!

@willbarton willbarton merged commit 804dcfb into cfpb:main Nov 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants