Improve admin UI and add extensible stylesheet #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
willbarton
reviewed
May 22, 2018
| def get_index_view_extra_css(self): | ||
| css = ['treemodeladmin/css/index.css'] | ||
| css.extend(self.index_view_extra_css) | ||
| return css |
higs4281
reviewed
May 22, 2018
Adds a custom index.css stylesheet that brings treemodeladmin in line with Wagtail's admin UI styles. Also lets the user add their own stylesheets when extending TreeModelAdmin.
The index.html template already inherits the same basic block from modeladmin/index.html. https://github.com/wagtail/wagtail/blob/master/wagtail/contrib/modeladmin/templates/modeladmin/index.html#L6-L9 This will fix the index.css file being included twice.
willbarton
force-pushed
the
add-stylesheet
branch
from
5df9d8a
to
33e8f5a
Compare
higs4281
approved these changes
May 24, 2018
|
Nice catch on the fix 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a custom index.css stylesheet that brings treemodeladmin in line with Wagtail's admin UI styles. Also lets the user add their own stylesheets when extending TreeModelAdmin.
@willbarton @higs4281 LMK how you feel about this approach. It's influenced by what modeladmin did before it was merged into wagtail core.
I only added a couple CSS rules to fix the buttons in the header. The arrows' spacing looks fine on my screen but I may be looking at the wrong thing. Let's chat what other fixes need to be made in post-scrum.
Additions
forms.Media.Testing
Editbutton in the header should look like a normal edit button.Screenshots
Checklist