Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new interactive tox environment #36

Merged
merged 2 commits into from
Jan 9, 2023
Merged

Conversation

chosak
Copy link
Member

@chosak chosak commented Dec 21, 2022

This commit adds a new tox -e interactive that runs a local test server with test data, to make it easier to test this project.

This is a nice feature that wagtail-localize has that I've also added to wagtail-inventory.

Testing

tox -e interactive

Todos

This project's README doesn't yet have a section about testing. It would make sense for this to go there.

Checklist

  • PR has an informative and human-readable title
  • Changes are limited to a single goal (no scope creep)
  • Code can be automatically merged (no conflicts)
  • Code follows the standards laid out in the development playbook
  • Passes all existing automated tests

This commit adds a new `tox -e interactive` that runs a local test
server with test data, to make it easier to test this project.

This is a nice feature that wagtail-localize has [0] that I've also
added to wagtail-inventory [1].

[0] https://www.wagtail-localize.org/#how-to-run-tests
[1] https://github.com/cfpb/wagtail-inventory#testing
Comment on lines +62 to +63
deps=
Django>=3.2,<3.3
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This shouldn't technically be needed, but I ran into an issue where tox doesn't seem to run the install_command unless there is some dependency defined for the environment (try removing this section and see what happens).

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤔

Copy link
Member

@willbarton willbarton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I love it! Let's add it to everything!

@chosak
Copy link
Member Author

chosak commented Dec 21, 2022

Tests are failing against Python 3.6, I think because of actions/setup-python#544.

I notice you remove testing against 3.6 in #34; let's get that one merged in first, and then merge this one?

@willbarton willbarton merged commit 39ad777 into main Jan 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants