Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vertically align content in admin table #6

Merged
merged 2 commits into from
May 25, 2018
Merged

Conversation

contolini
Copy link
Member

@contolini contolini commented May 24, 2018

Align content in admin tables to the top of cells (except the final "children" cells so that the arrow/plus icons stay centered).

Changes

  • Align admin content to top of cells.

Screenshots

Before:

screen shot 2018-05-24 at 5 37 25 pm

After:

screen shot 2018-05-24 at 5 36 31 pm

Notes

  • Wagtail core hardcodes vertical alignment in the templates instead of using CSS. CSS seems preferable.

Checklist

  • PR has an informative and human-readable title
  • Changes are limited to a single goal (no scope creep)
  • Code can be automatically merged (no conflicts)
  • Code follows the standards laid out in the development playbook
  • Passes all existing automated tests
  • Any change in functionality is tested
  • New functions are documented (with a description, list of inputs, and expected output)
  • Placeholder code is flagged / future todos are captured in comments
  • Visually tested in supported browsers and devices (see checklist below 👇)
  • Project documentation has been updated (including the "Unreleased" section of the CHANGELOG)
  • Reviewers requested with the Reviewers tool ➡️

@contolini contolini requested a review from willbarton May 24, 2018 21:41
@willbarton
Copy link
Member

Wagtail core hardcodes vertical alignment in the templates instead of using CSS. CSS seems preferable.

I prefer it!

@willbarton willbarton merged commit c14ac27 into master May 25, 2018
@willbarton willbarton deleted the vertical-alignment branch May 25, 2018 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants