Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make breadcrumbs show specific parents when they exist #7

Merged
merged 1 commit into from
Jun 12, 2018

Conversation

willbarton
Copy link
Member

This PR changes the way TreeModelAdmin generates breadcrumbs. Where before the crumbs would include only the plural name of the parent models, even if we're "inside" a particular parent. This PR changes the breadcrumbs to display str(parent_instance) instead of the plural name of the model.

The test app before:

image

The test app after:

image

I've bumped the version number in setup.py in anticipation of releasing this.

Checklist

  • PR has an informative and human-readable title
  • Changes are limited to a single goal (no scope creep)
  • Code can be automatically merged (no conflicts)
  • Code follows the standards laid out in the development playbook
  • Passes all existing automated tests
  • Any change in functionality is tested
  • New functions are documented (with a description, list of inputs, and expected output)
  • Placeholder code is flagged / future todos are captured in comments
  • Visually tested in supported browsers and devices (see checklist below 👇)
  • Project documentation has been updated (including the "Unreleased" section of the CHANGELOG)
  • Reviewers requested with the Reviewers tool ➡️

@coveralls
Copy link

coveralls commented Jun 12, 2018

Pull Request Test Coverage Report for Build 53

  • 6 of 6 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.5%) to 100.0%

Totals Coverage Status
Change from base Build 32: 0.5%
Covered Lines: 208
Relevant Lines: 208

💛 - Coveralls

@willbarton
Copy link
Member Author

With Reguations 3000:
image

Copy link
Member

@higs4281 higs4281 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's helpful to be able to see where you are.

@willbarton willbarton merged commit d507eca into master Jun 12, 2018
@willbarton willbarton deleted the specific-breadcrumbs branch June 12, 2018 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants