Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

💡 Update comments and strings with MultipartFile #2308

Merged
merged 6 commits into from
Oct 7, 2024

Conversation

AlexV525
Copy link
Member

@AlexV525 AlexV525 commented Oct 7, 2024

Resolves #1889 (comment)

New Pull Request Checklist

  • I have read the Documentation
  • I have searched for a similar pull request in the project and found none
  • I have updated this branch with the latest main branch to avoid conflicts (via merge from master or rebase)
  • I have added the required tests to prove the fix/feature I'm adding
  • I have updated the documentation (if necessary)
  • I have run the tests without failures
  • I have updated the CHANGELOG.md in the corresponding package

Additional context and info (if any)

Should we auto-clone the multipart file when it's been finalized?

@AlexV525 AlexV525 requested a review from a team as a code owner October 7, 2024 02:14
@@ -90,7 +90,6 @@ class MultipartFile {
utf8,
);
contentType = contentType.change(parameters: {'charset': encoding.name});
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here is a potential bug that will change the charset regardless of the input.

Copy link
Contributor

@ueman ueman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some typo nits, but otherwise it LGTM

dio/lib/src/multipart_file.dart Outdated Show resolved Hide resolved
dio/test/multipart_file_test.dart Outdated Show resolved Hide resolved
dio/lib/src/multipart_file.dart Outdated Show resolved Hide resolved
dio/lib/src/multipart_file.dart Outdated Show resolved Hide resolved
dio/lib/src/multipart_file.dart Outdated Show resolved Hide resolved
dio/lib/src/multipart_file.dart Outdated Show resolved Hide resolved
AlexV525 and others added 3 commits October 7, 2024 14:23
Co-authored-by: Jonas Uekötter <ueman@users.noreply.github.com>
Signed-off-by: Alex Li <github@alexv525.com>
Signed-off-by: Alex Li <github@alexv525.com>
Signed-off-by: Alex Li <github@alexv525.com>
Copy link
Contributor

github-actions bot commented Oct 7, 2024

Code Coverage Report: Only Changed Files listed

Package Base Coverage New Coverage Difference
Overall Coverage 🟢 84.7% 🟢 84.7% ⚪ 0%

Minimum allowed coverage is 0%, this run produced 84.7%

@AlexV525 AlexV525 merged commit d0838a2 into main Oct 7, 2024
3 checks passed
@AlexV525 AlexV525 deleted the chore/multipart-file-comment branch October 7, 2024 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants