Add method for arbitrary SFH to construct_x0_mdf
#48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #48 +/- ##
==========================================
+ Coverage 88.30% 88.50% +0.19%
==========================================
Files 18 18
Lines 1497 1523 +26
==========================================
+ Hits 1322 1348 +26
Misses 175 175 ☔ View full report in Codecov by Sentry. |
New method takes `cum_sfh = (cum_logAge, cum_vals)` and interpolates them onto the first `logAge` argument. This way you don't have to define your custom SFH on the same log(age) grid that you are using for your isochrones / templates.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By default
construct_x0_mdfassumes a constant SFR. A new dispatch has been added to this method to support a user-provided cumulative SFH.