-
-
Notifications
You must be signed in to change notification settings - Fork 94
Upgrade mocha dependency #203
Comments
This is very interesting, Chris. I didn't know where the warning was coming from. I think we'll also have to upgrade it in Buidler. @tmilar has already reviewed the breaking changes introduced in v6 and v7, and IIRC they aren't significant. Is this right, Tomi? |
Hi guys, yes I've reviewed the changelist of mocha v6 and v7 a few weeks ago, and arrived to the conclusion that there shouldn't be any issue with upgrading to latest v7 in buidler. |
Now that I think about it, this project may use different parts of Mocha's
api.
Should we coordinate an upgrade between this project, buidler and truffle?
…On Tue, 7 Apr 2020 at 16:20 Tomás Milar ***@***.***> wrote:
Hi guys, yes I've reviewed the changelist of mocha v6 and v7 a few weeks
ago, and arrived to the conclusion that there shouldn't be any issue with
upgrading to latest v7 in buidler.
I can check it out again if you want, and if everything is smooth, send a
PR.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#203 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AABLC45UCB4YG2BFXP4LF43RLN4JVANCNFSM4MDLTYFQ>
.
|
@alcuadrado @tmilar Yes, happy to coordinate. Last summer there was something about v6 that crashed the reporter. Will need to see if that's still happening on either 6 or 7 and address it. I'll open an exploratory PR this evening. |
Upgraded to Mocha 7. |
@alcuadrado @tmilar Do either of you have reservations about upgrading to Mocha 7? Am not seeing any problems in the E2E tests here and the breaking changes from release notes across 6 and 7 seem like they might not affect many people...idk. Am comfortable releasing the change here as a patch fwiw. |
|
Mocha 5 is afflicted by the minimist vuln warning :/
Mocha 6 has breaking changes...
The text was updated successfully, but these errors were encountered: