Convert file path to a string to avoid "Warning: Path must be a string" #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…g. Received [ 'index.html' ] Use --force to continue."
fayebutler
pushed a commit
to fayebutler/grunt-dom-munger
that referenced
this pull request
Sep 7, 2018
|
This has been fixed in the latest push, thanks for the pr. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If "isPath" is set, I had problems with grunt.file.expand returning an array, which grunt.dirname did not appear to like and threw out the error:
Warning: Path must be a string. Received [ 'index.html' ] Use --force to continue.Converting the array to a String with toString seems to solve the issue. In addition if there are older versions of grunt/node that aren't having grunt.file.expand pass an array, calling toString() on a String should have no effect. This should make this backwards compatible.