sys/net/routing/ng_rpl: Add default case for missing OCP implementation #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
but maybe dropping the packet is a better solution? |
| ng_rpl_of_t *of = ng_rpl_get_of_for_ocp(byteorder_ntohs(dc->ocp)); | ||
| if (of != NULL) { | ||
| dodag->instance->of = of; | ||
| } else { |
|
IMHO ignoring these packets would be the proper way to handle this case. Otherwise, the rank value will have different meanings for nodes supporting the OCP and nodes not supporting the OCP |
|
@cgundogan could you adapt and incorporate that in your big initial ng_rpl PR? (dropping the packet) |
|
Sure, but please address the styling issue (line break before |
jnohlgard
force-pushed
the
spr/cgundogan/ng_rpl_fib/rpl-ocp-default
branch
from
abb8c60 to
2a8580e
Compare
|
rebased and addressed |
cgundogan
added a commit
that referenced
this pull request
Jul 22, 2015
…fault sys/net/routing/ng_rpl: Add default case for missing OCP implementation
cgundogan
pushed a commit
that referenced
this pull request
May 27, 2019
…onal sys: make uart_stdio RX optional (attempt #2)
cgundogan
pushed a commit
that referenced
this pull request
Aug 21, 2019
The evtimer_msg test is expanded to also delete entries. Furthermore the messages that are printed should now show numbers that are very close (if not equal). Something like this: At 740 ms received msg 0: "#2 supposed to be 740" At 1081 ms received msg 1: "#0 supposed to be 1081" At 1581 ms received msg 2: "#1 supposed to be 1581" At 4035 ms received msg 3: "#3 supposed to be 4035" The function evtimer_print is also called to show the intermediate status of evtimer entries.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It used to crash when receiving a MRHOF RPL message when only OF0 is implemented.