New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Player] Various improvements #1189

Merged

frankrousseau merged 3 commits into cgwire:master from frankrousseau:master

Sep 18, 2023

Contributor

frankrousseau commented Sep 15, 2023

Problem

The max duration is wrong in Chrome (in the player and the playlist).
It's not possible to do overlay comparisons in the player.
The compared version annotations are not displayed.

Solution

Remove the previously needed hack in Chrome
Add the capability to overlay compared reviews in the player.
Load compared annotations in the video progress (show them with faded marks) and show them when the frame is clicked.

frankrousseau added 3 commits

September 15, 2023 16:22


          [previews] Fix max duration error with chrome

bfc7879


          [previews] Add overlay to the simple player

c2fb00f


          [previews] Allow to see annotations from the compared element

30b262a

mergify bot assigned frankrousseau

frankrousseau merged commit 44c4015 into cgwire:master

4 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet