Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve task comments #1216

Merged
merged 5 commits into from
Oct 11, 2023
Merged

Improve task comments #1216

merged 5 commits into from
Oct 11, 2023

Conversation

NicoPennec
Copy link
Member

Problem

  • On the Task panel, some draft comments don't clear after updating.
  • On Task page, the shortcut to copy the "Comment from client" doesn't work.
  • When opening a task, the focus is set to the comment field, but with the caret at the beginning.
  • On edit and reply comment form, you cannot use the @frame and @department tags (related to not possible to add @frame when editing a comment #897).
  • On realtime update between users, the comment update doesn't apply.

Solution

  • Rework the way to restore and save draft comments.
  • Fix the duplicate comment action.
  • Set the focus cursor at the end of the draft comment.
  • Harmonize add/edit/reply comment forms to support all tags.
  • Update comment on websocket push event

@NicoPennec NicoPennec merged commit efbbaae into cgwire:master Oct 11, 2023
4 checks passed
@NicoPennec NicoPennec deleted the fix/comment branch October 11, 2023 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants