Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[csv] add missing sanitize for some csv import + stop removing ';' an… #1248

Merged
merged 2 commits into from
Nov 23, 2023
Merged

[csv] add missing sanitize for some csv import + stop removing ';' an… #1248

merged 2 commits into from
Nov 23, 2023

Conversation

EvanBldy
Copy link
Member

@EvanBldy EvanBldy commented Nov 23, 2023 •
edited
Loading

…d add always double quotes

Problem

  • Some csv imports aren't sanitized before sending them to Zou.
  • We remove delimiter ";" and don't double double quotes so it's not properly recognized by Zou (and it can leads to wrong behavior)

Solution

  • Sanitize every csv import before sending it to Zou.
  • Only double double quotes and always put the cell between double quote.

@NicoPennec NicoPennec self-requested a review November 23, 2023 14:07
@EvanBldy @NicoPennec
Update src/components/pages/Breakdown.vue
f55793f 
Co-authored-by: Nicolas PENNEC <493223+NicoPennec@users.noreply.github.com>
@NicoPennec NicoPennec merged commit 2717c70 into cgwire:master Nov 23, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NicoPennec NicoPennec NicoPennec approved these changes

Assignees

@frankrousseau frankrousseau

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@EvanBldy @NicoPennec @frankrousseau