Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Various fixes #1254

Merged
merged 6 commits into from
Nov 27, 2023
Merged

Various fixes #1254

merged 6 commits into from
Nov 27, 2023

Conversation

frankrousseau
Copy link
Contributor

Problem

  • Panels in entity pages don't have the same behavior than in the entity list page.
  • In the playlist page, switching to full screen can break when a big picture is displayed.
  • It's not possible to filter on all assignations of an artist in the entity list pages.

Solution

  • Set the right options on the entity page task panel.
  • Fire a resize event after a switch to full screen.
  • Allow to select all task types when filtering on assignations.

@frankrousseau
[previews] Refactor preview player way of selecting frames
e66cfd3 
* Rely as least as possible on the html video player to set times
* Store the current frame position and use to apply the right timing
  when a modification occurs.
@frankrousseau
[qa] Aplly linter and remove debug logs
48eef75
@frankrousseau frankrousseau merged commit 7a5af76 into cgwire:master Nov 27, 2023
2 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@frankrousseau frankrousseau

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@frankrousseau