Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix annotation loading for videos #1262

Merged
merged 2 commits into from
Dec 13, 2023
Merged

Fix annotation loading for videos #1262

merged 2 commits into from
Dec 13, 2023

Conversation

frankrousseau
Copy link
Contributor

Problem

  • Annotations can be lost because they are tied to a frame time + 0.0000001.
  • The playlist player may become black when resizing or switching to full screen.

Solution

  • Make annotation loading more loosy.
  • Force precision to 4 digits when retrieving the current time.
  • Use always the container to compute the height of the player.

@frankrousseau
[playlists] Fix resize blinks
9f498d2
@frankrousseau
[previews] Clean annotation finding
b199cb8 
The current time used can be problematic because it doesn't exactly
matched a given frame due to float precision.

This commit makes current time computation closer to their related frame
and make annotation loading loosier about the time of the annotation to
grab.
@frankrousseau frankrousseau merged commit 84117e6 into cgwire:master Dec 13, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@frankrousseau frankrousseau

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@frankrousseau