Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various fixes #1580

Merged
merged 5 commits into from
Nov 6, 2024
Merged

Various fixes #1580

merged 5 commits into from
Nov 6, 2024

Conversation

NicoPennec
Copy link
Member

Problem

  • On the Breakdown page, toggle the casting on Picture mode, select a line with an asset, and click on the "+1" button. The action will fail, and a UUID value will be displayed.
  • On the Breakdown page, select two lines in the casting: a line with an item and a line without items, then click on the "-1" button. A silent error will be raised in the developer console.
  • On the Task Type page, updating an estimate file will incorrectly update the start/end dates.
  • An UX glitch on the user menu in the Japanese language (see When Kitsu is switched to Japanese, a piece of the personal menu remains displayed #1571).
  • On the Shot page, In the Casting section, display the Ready For status of a shared asset is not wanted.

Solution

  • On the Breakdown page, fix the add/remove one asset action. A wrong parameter could be passed to the method
  • On the Breakdown page, fix the remove one asset action with a multiple line selection. Check empty values before run actions.
  • On the Task Type page, fix the update of task estimation. Add a missing parameter.
  • Fix an overflow glitch when the user menu is closed. Remove the component if closed and use keyframes for the opening animation.
  • On the Shot page, hide the Ready For status for shared assets in the Casting section.

@frankrousseau frankrousseau merged commit f7c0323 into cgwire:master Nov 6, 2024
6 checks passed
@NicoPennec NicoPennec deleted the fix/various branch November 7, 2024 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants