New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

various improvements #1601

Merged

frankrousseau merged 2 commits into cgwire:main from EvanBldy:main

Dec 11, 2024

Member

EvanBldy commented Dec 11, 2024

Problem

Due to this PR (various improvements zou#895), page_size is changed with limit.
When uploading a movie preview a warning message always tells that there's a wrong number of frames in that movie preview.

Solution

The page_size query parameter for getEvents has been changed with a limit.
Fix frame calculation from the original movie (no need to add one frame in the calculation) + don't show this warning if there's no information about frame duration in that entity + fix locales

EvanBldy added 2 commits

December 6, 2024 16:03


          [events] parameter has changed for page_size it's limit now

00156f8


          [preview] Fix number of frames calculation for the warning message wh…

…en uploading a preview

mergify bot assigned frankrousseau

frankrousseau merged commit 7070230 into cgwire:main

2 of 6 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet