Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various fixes #1603

Merged
merged 8 commits into from
Dec 13, 2024
Merged

Various fixes #1603

merged 8 commits into from
Dec 13, 2024

Conversation

frankrousseau
Copy link
Contributor

Problem

  • Pinned revisions can be confused with being the last revision.
  • Task columns with no department are hidden when a department filter is selected in entity pages.
  • Shots loading doesn't occur when the episode is changed outside of the shot page.
  • The set current frame as thumbnail option selects the previous frame instead of the current frame.
  • Task type stats is not properly displayed in the production page.

Solution

  • Change revision label to "Pinned Revision" for revisions in pinned comments
  • Include task columns with no department in the selected column when a department is selected
  • Check if the episode changed on Shots page mount.
  • Add 1 frame to the selected frame to match ffmpeg way of counting frames
  • Use the right number to compute the width of colored bars showing the amount of tasks for each status

@@ -1315,7 +1315,7 @@ export default {
this.loading.setFrameThumbnail = true
let frame = null
if (isUseCurrentFrame) {
frame = this.currentFrameRaw
frame = this.currentFrameRaw + 1
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a comment on this line to explain why "+ 1".
It will be easier to read and understand the code later (git blame is not viable over time)

@NicoPennec NicoPennec merged commit b991299 into cgwire:main Dec 13, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants