Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(otg_v2): correct UEP_DMA bit_size from 16 to 32 #7

Merged
merged 1 commit into from
Sep 18, 2024

Conversation

Dummyc0m
Copy link
Member

Fix applied according to the datasheet.

Fix applied according to the datasheet.
@andelf
Copy link
Contributor

andelf commented Sep 15, 2024

Could you provide the source of the change? According to the RM doc:

image image

@Codetector1374
Copy link
Member

😮‍💨 Sigh.... WCH documentation is inconsistent at best...

This is from CH32FV2x_3xRM.pdf

Screenshot 2024-09-15 at 10 59 45 AM

The address map also agrees with this, each of the DMA register are spaced 4 apart:

Screenshot 2024-09-15 at 11 01 48 AM

Logically it also makes sense, since we are expected to fill a memory address into there, which would be 32 bits.

The register name on my manual seems to be R32 indicating it is a 32bit register.

@Codetector1374
Copy link
Member

@andelf if you get a chance to take a look at this would be extremely helpful :)

@andelf andelf self-requested a review September 18, 2024 05:28
@andelf
Copy link
Contributor

andelf commented Sep 18, 2024

Thanks! I'll check the EVT source code for these registers.

@Codetector1374
Copy link
Member

Codetector1374 commented Sep 18, 2024 via email

@andelf
Copy link
Contributor

andelf commented Sep 18, 2024

Let's get this merged.

@andelf andelf merged commit 0f2f911 into ch32-rs:main Sep 18, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants