Add support for ATD #200
Merged
Add support for ATD #200
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is so weird. Why do I get vastly different outputs in CI? |
|
CPU vs GPU? |
|
I use CPU for tests locally as well. |
|
maybe its linux thats the problem? i have no idea what else it could be |
|
Okay, so I just did test runs on CPU vs GPU. It seems like ATD is highly sensitive to floating point impression. When I compare the output of my CPU vs GPU, I get the same type of large error as we see with CI. Despite the large error, the two outputs are visually the same, so I think I'm going to add another error metric to account for this. |
|
Finally. |
joeyballentine
approved these changes
Mar 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for ATD.