-
-
Notifications
You must be signed in to change notification settings - Fork 698
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ES module conversion PoC #1498
ES module conversion PoC #1498
Conversation
The changes made in chaijs#1334 incorrectly used an arrow function and as this isn't supported on IE 11 it causes a SyntaxError to be thrown when loading chai.
Bumps [codecov](https://github.com/codecov/codecov-node) from 3.1.0 to 3.7.1. - [Release notes](https://github.com/codecov/codecov-node/releases) - [Changelog](https://github.com/codecov/codecov-node/blob/master/CHANGELOG.md) - [Commits](codecov/codecov-node@v3.1.0...v3.7.1) --- updated-dependencies: - dependency-name: codecov dependency-type: direct:development ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* 4.x.x: Fix link to commit logs on GitHub As there is no `master` branch, the link returned a 404. * Update History.md Co-authored-by: Andre Meyering <info@andremeyering.de> Co-authored-by: Keith Cirkel <keithamus@users.noreply.github.com>
Bumps [socket.io-parser](https://github.com/socketio/socket.io-parser) from 4.0.4 to 4.0.5. - [Release notes](https://github.com/socketio/socket.io-parser/releases) - [Changelog](https://github.com/socketio/socket.io-parser/blob/main/CHANGELOG.md) - [Commits](socketio/socket.io-parser@4.0.4...4.0.5) --- updated-dependencies: - dependency-name: socket.io-parser dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
previously it was incorrectly labeled as `objDisplay(obj: object): void` in `@types/chai`.
This moves all of the sources to be ES modules rather than CommonJS. In order to produce the entrypoints, we use esbuild as a bundler (and as a transpiler in a way). Due to the fact that some dependencies are written in CommonJS, we actually use esbuild to create _two_ bundles: a CommonJS bundle, and an ES module bundle. Otherwise, someone importing the raw source would inevitably end up trying to import a CommonJS module somewhere down the tree, which would not work in browsers natively.
@keithamus did you ever get chance to take a peek at this? would be good to get some thoughts giving chai a real es module would be so useful |
Thanks for the reminder! I’ll give this a closer look tomorrow ❤️ |
Hopefully by dropping older engines and CommonJS we can ensure that Chai is able to evolve with the rest of the ecosystem! |
@keithamus just saw your post about this. we haven't actually dropped commonjs yet. you can still require() the alpha. if the plan is to not support it, we can halve the npm package size by dropping the commonjs bundle i left in here 👀 do you want me to do that in a separate PR? |
@43081j I understand you created the cjs files in this PR, but yes, I think let's make a clean break from CommonJS to ease releasing. If you're happy to make the separate PR I'm happy to accept it 😄 |
Sure happy to do that. Right now it means there's two bundles basically, double the package size because of needing esm and cjs Would love to drop the cjs one. We still need to bundle because of cjs dependencies but at least it'll get rid of one of the two bundles |
Right. I'd also like to convert the cjs deps we have, like loupe. |
Yup I agree End goal should be a purely esm dependency tree. So we don't have to bundle at all and can ship the sources as is Maybe an issue to track any incompatible dependencies would be good. There's possibly a few |
[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [chai](http://chaijs.com) ([source](https://github.com/chaijs/chai)) | [`4.4.1` -> `5.1.1`](https://renovatebot.com/diffs/npm/chai/4.4.1/5.1.1) | [![age](https://developer.mend.io/api/mc/badges/age/npm/chai/5.1.1?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/chai/5.1.1?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/chai/4.4.1/5.1.1?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/chai/4.4.1/5.1.1?slim=true)](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>chaijs/chai (chai)</summary> ### [`v5.1.1`](https://github.com/chaijs/chai/releases/tag/v5.1.1) [Compare Source](https://github.com/chaijs/chai/compare/v5.1.0...v5.1.1) #### What's Changed - Set up ESLint for JSDoc comments by [@​koddsson](https://github.com/koddsson) in [https://github.com/chaijs/chai/pull/1605](https://github.com/chaijs/chai/pull/1605) - build(deps-dev): bump ip from 1.1.8 to 1.1.9 by [@​dependabot](https://github.com/dependabot) in [https://github.com/chaijs/chai/pull/1608](https://github.com/chaijs/chai/pull/1608) - Correct Mocha import instructions by [@​MattiSG](https://github.com/MattiSG) in [https://github.com/chaijs/chai/pull/1611](https://github.com/chaijs/chai/pull/1611) - fix: support some virtual contexts in `toThrow` by [@​43081j](https://github.com/43081j) in [https://github.com/chaijs/chai/pull/1609](https://github.com/chaijs/chai/pull/1609) #### New Contributors - [@​MattiSG](https://github.com/MattiSG) made their first contribution in [https://github.com/chaijs/chai/pull/1611](https://github.com/chaijs/chai/pull/1611) **Full Changelog**: chaijs/chai@v5.1.0...v5.1.1 ### [`v5.1.0`](https://github.com/chaijs/chai/releases/tag/v5.1.0) [Compare Source](https://github.com/chaijs/chai/compare/v5.0.3...v5.1.0) #### What's Changed - Remove useless guards and add parentheses to constuctors by [@​koddsson](https://github.com/koddsson) in [https://github.com/chaijs/chai/pull/1593](https://github.com/chaijs/chai/pull/1593) - Cleanup jsdoc comments by [@​koddsson](https://github.com/koddsson) in [https://github.com/chaijs/chai/pull/1596](https://github.com/chaijs/chai/pull/1596) - Convert comments in "legal comments" format to jsdoc or normal comments by [@​koddsson](https://github.com/koddsson) in [https://github.com/chaijs/chai/pull/1598](https://github.com/chaijs/chai/pull/1598) - Implement `iterable` assertion by [@​koddsson](https://github.com/koddsson) in [https://github.com/chaijs/chai/pull/1592](https://github.com/chaijs/chai/pull/1592) - Assert interface fix by [@​developer-bandi](https://github.com/developer-bandi) in [https://github.com/chaijs/chai/pull/1601](https://github.com/chaijs/chai/pull/1601) - Set support in same members by [@​koddsson](https://github.com/koddsson) in [https://github.com/chaijs/chai/pull/1583](https://github.com/chaijs/chai/pull/1583) - Fix publish script by [@​koddsson](https://github.com/koddsson) in [https://github.com/chaijs/chai/pull/1602](https://github.com/chaijs/chai/pull/1602) #### New Contributors - [@​developer-bandi](https://github.com/developer-bandi) made their first contribution in [https://github.com/chaijs/chai/pull/1601](https://github.com/chaijs/chai/pull/1601) **Full Changelog**: chaijs/chai@v5.0.3...v5.1.0 ### [`v5.0.3`](https://github.com/chaijs/chai/releases/tag/v5.0.3) [Compare Source](https://github.com/chaijs/chai/compare/v5.0.2...v5.0.3) Fix bad v5.0.2 publish. **Full Changelog**: chaijs/chai@v5.0.2...v5.0.3 ### [`v5.0.2`](https://github.com/chaijs/chai/releases/tag/v5.0.2) [Compare Source](https://github.com/chaijs/chai/compare/v5.0.0...v5.0.2) #### What's Changed - build(deps): bump nanoid and mocha by [@​dependabot](https://github.com/dependabot) in [https://github.com/chaijs/chai/pull/1558](https://github.com/chaijs/chai/pull/1558) - remove `bump-cli` by [@​koddsson](https://github.com/koddsson) in [https://github.com/chaijs/chai/pull/1559](https://github.com/chaijs/chai/pull/1559) - Update developer dependencies by [@​koddsson](https://github.com/koddsson) in [https://github.com/chaijs/chai/pull/1560](https://github.com/chaijs/chai/pull/1560) - fix: removes `??` for node compat (5.x) by [@​43081j](https://github.com/43081j) in [https://github.com/chaijs/chai/pull/1576](https://github.com/chaijs/chai/pull/1576) - Update `loupe` to latest version by [@​koddsson](https://github.com/koddsson) in [https://github.com/chaijs/chai/pull/1579](https://github.com/chaijs/chai/pull/1579) - Re-enable some webkit tests by [@​koddsson](https://github.com/koddsson) in [https://github.com/chaijs/chai/pull/1580](https://github.com/chaijs/chai/pull/1580) - Remove a bunch of if statements in test/should.js by [@​koddsson](https://github.com/koddsson) in [https://github.com/chaijs/chai/pull/1581](https://github.com/chaijs/chai/pull/1581) - Remove a bunch of unused files by [@​koddsson](https://github.com/koddsson) in [https://github.com/chaijs/chai/pull/1582](https://github.com/chaijs/chai/pull/1582) - Fix 1564 by [@​koddsson](https://github.com/koddsson) in [https://github.com/chaijs/chai/pull/1566](https://github.com/chaijs/chai/pull/1566) **Full Changelog**: chaijs/chai@v5.0.1...v5.0.2 ### [`v5.0.0`](https://github.com/chaijs/chai/releases/tag/v5.0.0) [Compare Source](https://github.com/chaijs/chai/compare/v4.4.1...v5.0.0) #### BREAKING CHANGES - Chai now only supports EcmaScript Modules (ESM). This means your tests will need to either have `import {...} from 'chai'` or `import('chai')`. `require('chai')` will cause failures in nodejs. If you're using ESM and seeing failures, it may be due to a bundler or transpiler which is incorrectly converting import statements into require calls. - Dropped support for Internet Explorer. - Dropped support for NodeJS < 18. - Minimum supported browsers are now Firefox 100, Safari 14.1, Chrome 100, Edge 100. Support for browsers prior to these versions is "best effort" (bug reports on older browsers will be assessed individually and may be marked as wontfix). #### What's Changed - feat: use chaijs/loupe for inspection by [@​pcorpet](https://github.com/pcorpet) in [https://github.com/chaijs/chai/pull/1401](https://github.com/chaijs/chai/pull/1401) - docs: fix URL in README by [@​Izzur](https://github.com/Izzur) in [https://github.com/chaijs/chai/pull/1413](https://github.com/chaijs/chai/pull/1413) - Remove `get-func-name` dependency by [@​koddsson](https://github.com/koddsson) in [https://github.com/chaijs/chai/pull/1416](https://github.com/chaijs/chai/pull/1416) - Convert Makefile script to npm scripts by [@​koddsson](https://github.com/koddsson) in [https://github.com/chaijs/chai/pull/1424](https://github.com/chaijs/chai/pull/1424) - Clean up README badges by [@​koddsson](https://github.com/koddsson) in [https://github.com/chaijs/chai/pull/1422](https://github.com/chaijs/chai/pull/1422) - fix: package.json - deprecation warning on exports field by [@​stevenjoezhang](https://github.com/stevenjoezhang) in [https://github.com/chaijs/chai/pull/1400](https://github.com/chaijs/chai/pull/1400) - fix: deep-eql bump package to support symbols by [@​snewcomer](https://github.com/snewcomer) in [https://github.com/chaijs/chai/pull/1458](https://github.com/chaijs/chai/pull/1458) - ES module conversion PoC by [@​43081j](https://github.com/43081j) in [https://github.com/chaijs/chai/pull/1498](https://github.com/chaijs/chai/pull/1498) - chore: drop commonjs support by [@​43081j](https://github.com/43081j) in [https://github.com/chaijs/chai/pull/1503](https://github.com/chaijs/chai/pull/1503) - Update pathval by [@​koddsson](https://github.com/koddsson) in [https://github.com/chaijs/chai/pull/1527](https://github.com/chaijs/chai/pull/1527) - Update check-error by [@​koddsson](https://github.com/koddsson) in [https://github.com/chaijs/chai/pull/1528](https://github.com/chaijs/chai/pull/1528) - update `deep-eql` to latest version by [@​koddsson](https://github.com/koddsson) in [https://github.com/chaijs/chai/pull/1542](https://github.com/chaijs/chai/pull/1542) - Inline `type-detect` as a simple function by [@​koddsson](https://github.com/koddsson) in [https://github.com/chaijs/chai/pull/1544](https://github.com/chaijs/chai/pull/1544) - Update loupe by [@​koddsson](https://github.com/koddsson) in [https://github.com/chaijs/chai/pull/1545](https://github.com/chaijs/chai/pull/1545) - Typo 'Test an object' not 'Test and object' by [@​mavaddat](https://github.com/mavaddat) in [https://github.com/chaijs/chai/pull/1460](https://github.com/chaijs/chai/pull/1460) - Update `assertion-error` to it's latest major version! by [@​koddsson](https://github.com/koddsson) in [https://github.com/chaijs/chai/pull/1543](https://github.com/chaijs/chai/pull/1543) - Replacing Karma with Web Test Runner by [@​koddsson](https://github.com/koddsson) in [https://github.com/chaijs/chai/pull/1546](https://github.com/chaijs/chai/pull/1546) #### New Contributors - [@​Izzur](https://github.com/Izzur) made their first contribution in [https://github.com/chaijs/chai/pull/1413](https://github.com/chaijs/chai/pull/1413) - [@​stevenjoezhang](https://github.com/stevenjoezhang) made their first contribution in [https://github.com/chaijs/chai/pull/1400](https://github.com/chaijs/chai/pull/1400) - [@​43081j](https://github.com/43081j) made their first contribution in [https://github.com/chaijs/chai/pull/1498](https://github.com/chaijs/chai/pull/1498) **Full Changelog**: chaijs/chai@4.3.1...v5.0.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/runtime-env/import-meta-env). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy40MjEuOSIsInVwZGF0ZWRJblZlciI6IjM3LjQyMS45IiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6W119--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Type | Update | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---|---|---| | [actions/setup-java](https://github.com/actions/setup-java) | action | major | `v3` -> `v4` | [![age](https://developer.mend.io/api/mc/badges/age/github-tags/actions%2fsetup-java/v4?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/github-tags/actions%2fsetup-java/v4?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/github-tags/actions%2fsetup-java/v3/v4?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/github-tags/actions%2fsetup-java/v3/v4?slim=true)](https://docs.renovatebot.com/merge-confidence/) | | [chai](http://chaijs.com) ([source](https://github.com/chaijs/chai)) | devDependencies | major | [`4.5.0` -> `5.1.1`](https://renovatebot.com/diffs/npm/chai/4.5.0/5.1.1) | [![age](https://developer.mend.io/api/mc/badges/age/npm/chai/5.1.1?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/chai/5.1.1?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/chai/4.5.0/5.1.1?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/chai/4.5.0/5.1.1?slim=true)](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>actions/setup-java (actions/setup-java)</summary> ### [`v4`](https://github.com/actions/setup-java/compare/v3...v4) [Compare Source](https://github.com/actions/setup-java/compare/v3...v4) </details> <details> <summary>chaijs/chai (chai)</summary> ### [`v5.1.1`](https://github.com/chaijs/chai/releases/tag/v5.1.1) [Compare Source](https://github.com/chaijs/chai/compare/v5.1.0...v5.1.1) #### What's Changed - Set up ESLint for JSDoc comments by [@​koddsson](https://github.com/koddsson) in [https://github.com/chaijs/chai/pull/1605](https://github.com/chaijs/chai/pull/1605) - build(deps-dev): bump ip from 1.1.8 to 1.1.9 by [@​dependabot](https://github.com/dependabot) in [https://github.com/chaijs/chai/pull/1608](https://github.com/chaijs/chai/pull/1608) - Correct Mocha import instructions by [@​MattiSG](https://github.com/MattiSG) in [https://github.com/chaijs/chai/pull/1611](https://github.com/chaijs/chai/pull/1611) - fix: support some virtual contexts in `toThrow` by [@​43081j](https://github.com/43081j) in [https://github.com/chaijs/chai/pull/1609](https://github.com/chaijs/chai/pull/1609) #### New Contributors - [@​MattiSG](https://github.com/MattiSG) made their first contribution in [https://github.com/chaijs/chai/pull/1611](https://github.com/chaijs/chai/pull/1611) **Full Changelog**: chaijs/chai@v5.1.0...v5.1.1 ### [`v5.1.0`](https://github.com/chaijs/chai/releases/tag/v5.1.0) [Compare Source](https://github.com/chaijs/chai/compare/v5.0.3...v5.1.0) #### What's Changed - Remove useless guards and add parentheses to constuctors by [@​koddsson](https://github.com/koddsson) in [https://github.com/chaijs/chai/pull/1593](https://github.com/chaijs/chai/pull/1593) - Cleanup jsdoc comments by [@​koddsson](https://github.com/koddsson) in [https://github.com/chaijs/chai/pull/1596](https://github.com/chaijs/chai/pull/1596) - Convert comments in "legal comments" format to jsdoc or normal comments by [@​koddsson](https://github.com/koddsson) in [https://github.com/chaijs/chai/pull/1598](https://github.com/chaijs/chai/pull/1598) - Implement `iterable` assertion by [@​koddsson](https://github.com/koddsson) in [https://github.com/chaijs/chai/pull/1592](https://github.com/chaijs/chai/pull/1592) - Assert interface fix by [@​developer-bandi](https://github.com/developer-bandi) in [https://github.com/chaijs/chai/pull/1601](https://github.com/chaijs/chai/pull/1601) - Set support in same members by [@​koddsson](https://github.com/koddsson) in [https://github.com/chaijs/chai/pull/1583](https://github.com/chaijs/chai/pull/1583) - Fix publish script by [@​koddsson](https://github.com/koddsson) in [https://github.com/chaijs/chai/pull/1602](https://github.com/chaijs/chai/pull/1602) #### New Contributors - [@​developer-bandi](https://github.com/developer-bandi) made their first contribution in [https://github.com/chaijs/chai/pull/1601](https://github.com/chaijs/chai/pull/1601) **Full Changelog**: chaijs/chai@v5.0.3...v5.1.0 ### [`v5.0.3`](https://github.com/chaijs/chai/releases/tag/v5.0.3) [Compare Source](https://github.com/chaijs/chai/compare/v5.0.2...v5.0.3) Fix bad v5.0.2 publish. **Full Changelog**: chaijs/chai@v5.0.2...v5.0.3 ### [`v5.0.2`](https://github.com/chaijs/chai/releases/tag/v5.0.2) [Compare Source](https://github.com/chaijs/chai/compare/v5.0.0...v5.0.2) #### What's Changed - build(deps): bump nanoid and mocha by [@​dependabot](https://github.com/dependabot) in [https://github.com/chaijs/chai/pull/1558](https://github.com/chaijs/chai/pull/1558) - remove `bump-cli` by [@​koddsson](https://github.com/koddsson) in [https://github.com/chaijs/chai/pull/1559](https://github.com/chaijs/chai/pull/1559) - Update developer dependencies by [@​koddsson](https://github.com/koddsson) in [https://github.com/chaijs/chai/pull/1560](https://github.com/chaijs/chai/pull/1560) - fix: removes `??` for node compat (5.x) by [@​43081j](https://github.com/43081j) in [https://github.com/chaijs/chai/pull/1576](https://github.com/chaijs/chai/pull/1576) - Update `loupe` to latest version by [@​koddsson](https://github.com/koddsson) in [https://github.com/chaijs/chai/pull/1579](https://github.com/chaijs/chai/pull/1579) - Re-enable some webkit tests by [@​koddsson](https://github.com/koddsson) in [https://github.com/chaijs/chai/pull/1580](https://github.com/chaijs/chai/pull/1580) - Remove a bunch of if statements in test/should.js by [@​koddsson](https://github.com/koddsson) in [https://github.com/chaijs/chai/pull/1581](https://github.com/chaijs/chai/pull/1581) - Remove a bunch of unused files by [@​koddsson](https://github.com/koddsson) in [https://github.com/chaijs/chai/pull/1582](https://github.com/chaijs/chai/pull/1582) - Fix 1564 by [@​koddsson](https://github.com/koddsson) in [https://github.com/chaijs/chai/pull/1566](https://github.com/chaijs/chai/pull/1566) **Full Changelog**: chaijs/chai@v5.0.1...v5.0.2 ### [`v5.0.0`](https://github.com/chaijs/chai/releases/tag/v5.0.0) [Compare Source](https://github.com/chaijs/chai/compare/v4.5.0...v5.0.0) #### BREAKING CHANGES - Chai now only supports EcmaScript Modules (ESM). This means your tests will need to either have `import {...} from 'chai'` or `import('chai')`. `require('chai')` will cause failures in nodejs. If you're using ESM and seeing failures, it may be due to a bundler or transpiler which is incorrectly converting import statements into require calls. - Dropped support for Internet Explorer. - Dropped support for NodeJS < 18. - Minimum supported browsers are now Firefox 100, Safari 14.1, Chrome 100, Edge 100. Support for browsers prior to these versions is "best effort" (bug reports on older browsers will be assessed individually and may be marked as wontfix). #### What's Changed - feat: use chaijs/loupe for inspection by [@​pcorpet](https://github.com/pcorpet) in [https://github.com/chaijs/chai/pull/1401](https://github.com/chaijs/chai/pull/1401) - docs: fix URL in README by [@​Izzur](https://github.com/Izzur) in [https://github.com/chaijs/chai/pull/1413](https://github.com/chaijs/chai/pull/1413) - Remove `get-func-name` dependency by [@​koddsson](https://github.com/koddsson) in [https://github.com/chaijs/chai/pull/1416](https://github.com/chaijs/chai/pull/1416) - Convert Makefile script to npm scripts by [@​koddsson](https://github.com/koddsson) in [https://github.com/chaijs/chai/pull/1424](https://github.com/chaijs/chai/pull/1424) - Clean up README badges by [@​koddsson](https://github.com/koddsson) in [https://github.com/chaijs/chai/pull/1422](https://github.com/chaijs/chai/pull/1422) - fix: package.json - deprecation warning on exports field by [@​stevenjoezhang](https://github.com/stevenjoezhang) in [https://github.com/chaijs/chai/pull/1400](https://github.com/chaijs/chai/pull/1400) - fix: deep-eql bump package to support symbols by [@​snewcomer](https://github.com/snewcomer) in [https://github.com/chaijs/chai/pull/1458](https://github.com/chaijs/chai/pull/1458) - ES module conversion PoC by [@​43081j](https://github.com/43081j) in [https://github.com/chaijs/chai/pull/1498](https://github.com/chaijs/chai/pull/1498) - chore: drop commonjs support by [@​43081j](https://github.com/43081j) in [https://github.com/chaijs/chai/pull/1503](https://github.com/chaijs/chai/pull/1503) - Update pathval by [@​koddsson](https://github.com/koddsson) in [https://github.com/chaijs/chai/pull/1527](https://github.com/chaijs/chai/pull/1527) - Update check-error by [@​koddsson](https://github.com/koddsson) in [https://github.com/chaijs/chai/pull/1528](https://github.com/chaijs/chai/pull/1528) - update `deep-eql` to latest version by [@​koddsson](https://github.com/koddsson) in [https://github.com/chaijs/chai/pull/1542](https://github.com/chaijs/chai/pull/1542) - Inline `type-detect` as a simple function by [@​koddsson](https://github.com/koddsson) in [https://github.com/chaijs/chai/pull/1544](https://github.com/chaijs/chai/pull/1544) - Update loupe by [@​koddsson](https://github.com/koddsson) in [https://github.com/chaijs/chai/pull/1545](https://github.com/chaijs/chai/pull/1545) - Typo 'Test an object' not 'Test and object' by [@​mavaddat](https://github.com/mavaddat) in [https://github.com/chaijs/chai/pull/1460](https://github.com/chaijs/chai/pull/1460) - Update `assertion-error` to it's latest major version! by [@​koddsson](https://github.com/koddsson) in [https://github.com/chaijs/chai/pull/1543](https://github.com/chaijs/chai/pull/1543) - Replacing Karma with Web Test Runner by [@​koddsson](https://github.com/koddsson) in [https://github.com/chaijs/chai/pull/1546](https://github.com/chaijs/chai/pull/1546) #### New Contributors - [@​Izzur](https://github.com/Izzur) made their first contribution in [https://github.com/chaijs/chai/pull/1413](https://github.com/chaijs/chai/pull/1413) - [@​stevenjoezhang](https://github.com/stevenjoezhang) made their first contribution in [https://github.com/chaijs/chai/pull/1400](https://github.com/chaijs/chai/pull/1400) - [@​43081j](https://github.com/43081j) made their first contribution in [https://github.com/chaijs/chai/pull/1498](https://github.com/chaijs/chai/pull/1498) **Full Changelog**: chaijs/chai@4.3.1...v5.0.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "after 2pm on Monday" in timezone Europe/Zurich, Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 👻 **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://github.com/renovatebot/renovate/discussions) if that's undesired. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR was generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View the [repository job log](https://developer.mend.io/github/adobe/spacecat-shared). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOC4yNi4xIiwidXBkYXRlZEluVmVyIjoiMzguMjYuMSIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOltdfQ==--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Dominique Jäggi <1872195+solaris007@users.noreply.github.com>
This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [chai](http://chaijs.com) ([source](https://redirect.github.com/chaijs/chai)) | [`^4.5.0` -> `^5.0.0`](https://renovatebot.com/diffs/npm/chai/4.5.0/5.1.1) | [![age](https://developer.mend.io/api/mc/badges/age/npm/chai/5.1.1?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/chai/5.1.1?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/chai/4.5.0/5.1.1?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/chai/4.5.0/5.1.1?slim=true)](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>chaijs/chai (chai)</summary> ### [`v5.1.1`](https://redirect.github.com/chaijs/chai/releases/tag/v5.1.1) [Compare Source](https://redirect.github.com/chaijs/chai/compare/v5.1.0...v5.1.1) #### What's Changed - Set up ESLint for JSDoc comments by [@​koddsson](https://redirect.github.com/koddsson) in [https://github.com/chaijs/chai/pull/1605](https://redirect.github.com/chaijs/chai/pull/1605) - build(deps-dev): bump ip from 1.1.8 to 1.1.9 by [@​dependabot](https://redirect.github.com/dependabot) in [https://github.com/chaijs/chai/pull/1608](https://redirect.github.com/chaijs/chai/pull/1608) - Correct Mocha import instructions by [@​MattiSG](https://redirect.github.com/MattiSG) in [https://github.com/chaijs/chai/pull/1611](https://redirect.github.com/chaijs/chai/pull/1611) - fix: support some virtual contexts in `toThrow` by [@​43081j](https://redirect.github.com/43081j) in [https://github.com/chaijs/chai/pull/1609](https://redirect.github.com/chaijs/chai/pull/1609) #### New Contributors - [@​MattiSG](https://redirect.github.com/MattiSG) made their first contribution in [https://github.com/chaijs/chai/pull/1611](https://redirect.github.com/chaijs/chai/pull/1611) **Full Changelog**: chaijs/chai@v5.1.0...v5.1.1 ### [`v5.1.0`](https://redirect.github.com/chaijs/chai/releases/tag/v5.1.0) [Compare Source](https://redirect.github.com/chaijs/chai/compare/v5.0.3...v5.1.0) #### What's Changed - Remove useless guards and add parentheses to constuctors by [@​koddsson](https://redirect.github.com/koddsson) in [https://github.com/chaijs/chai/pull/1593](https://redirect.github.com/chaijs/chai/pull/1593) - Cleanup jsdoc comments by [@​koddsson](https://redirect.github.com/koddsson) in [https://github.com/chaijs/chai/pull/1596](https://redirect.github.com/chaijs/chai/pull/1596) - Convert comments in "legal comments" format to jsdoc or normal comments by [@​koddsson](https://redirect.github.com/koddsson) in [https://github.com/chaijs/chai/pull/1598](https://redirect.github.com/chaijs/chai/pull/1598) - Implement `iterable` assertion by [@​koddsson](https://redirect.github.com/koddsson) in [https://github.com/chaijs/chai/pull/1592](https://redirect.github.com/chaijs/chai/pull/1592) - Assert interface fix by [@​developer-bandi](https://redirect.github.com/developer-bandi) in [https://github.com/chaijs/chai/pull/1601](https://redirect.github.com/chaijs/chai/pull/1601) - Set support in same members by [@​koddsson](https://redirect.github.com/koddsson) in [https://github.com/chaijs/chai/pull/1583](https://redirect.github.com/chaijs/chai/pull/1583) - Fix publish script by [@​koddsson](https://redirect.github.com/koddsson) in [https://github.com/chaijs/chai/pull/1602](https://redirect.github.com/chaijs/chai/pull/1602) #### New Contributors - [@​developer-bandi](https://redirect.github.com/developer-bandi) made their first contribution in [https://github.com/chaijs/chai/pull/1601](https://redirect.github.com/chaijs/chai/pull/1601) **Full Changelog**: chaijs/chai@v5.0.3...v5.1.0 ### [`v5.0.3`](https://redirect.github.com/chaijs/chai/releases/tag/v5.0.3) [Compare Source](https://redirect.github.com/chaijs/chai/compare/v5.0.2...v5.0.3) Fix bad v5.0.2 publish. **Full Changelog**: chaijs/chai@v5.0.2...v5.0.3 ### [`v5.0.2`](https://redirect.github.com/chaijs/chai/releases/tag/v5.0.2) [Compare Source](https://redirect.github.com/chaijs/chai/compare/v5.0.0...v5.0.2) #### What's Changed - build(deps): bump nanoid and mocha by [@​dependabot](https://redirect.github.com/dependabot) in [https://github.com/chaijs/chai/pull/1558](https://redirect.github.com/chaijs/chai/pull/1558) - remove `bump-cli` by [@​koddsson](https://redirect.github.com/koddsson) in [https://github.com/chaijs/chai/pull/1559](https://redirect.github.com/chaijs/chai/pull/1559) - Update developer dependencies by [@​koddsson](https://redirect.github.com/koddsson) in [https://github.com/chaijs/chai/pull/1560](https://redirect.github.com/chaijs/chai/pull/1560) - fix: removes `??` for node compat (5.x) by [@​43081j](https://redirect.github.com/43081j) in [https://github.com/chaijs/chai/pull/1576](https://redirect.github.com/chaijs/chai/pull/1576) - Update `loupe` to latest version by [@​koddsson](https://redirect.github.com/koddsson) in [https://github.com/chaijs/chai/pull/1579](https://redirect.github.com/chaijs/chai/pull/1579) - Re-enable some webkit tests by [@​koddsson](https://redirect.github.com/koddsson) in [https://github.com/chaijs/chai/pull/1580](https://redirect.github.com/chaijs/chai/pull/1580) - Remove a bunch of if statements in test/should.js by [@​koddsson](https://redirect.github.com/koddsson) in [https://github.com/chaijs/chai/pull/1581](https://redirect.github.com/chaijs/chai/pull/1581) - Remove a bunch of unused files by [@​koddsson](https://redirect.github.com/koddsson) in [https://github.com/chaijs/chai/pull/1582](https://redirect.github.com/chaijs/chai/pull/1582) - Fix 1564 by [@​koddsson](https://redirect.github.com/koddsson) in [https://github.com/chaijs/chai/pull/1566](https://redirect.github.com/chaijs/chai/pull/1566) **Full Changelog**: chaijs/chai@v5.0.1...v5.0.2 ### [`v5.0.0`](https://redirect.github.com/chaijs/chai/releases/tag/v5.0.0) [Compare Source](https://redirect.github.com/chaijs/chai/compare/v4.5.0...v5.0.0) #### BREAKING CHANGES - Chai now only supports EcmaScript Modules (ESM). This means your tests will need to either have `import {...} from 'chai'` or `import('chai')`. `require('chai')` will cause failures in nodejs. If you're using ESM and seeing failures, it may be due to a bundler or transpiler which is incorrectly converting import statements into require calls. - Dropped support for Internet Explorer. - Dropped support for NodeJS < 18. - Minimum supported browsers are now Firefox 100, Safari 14.1, Chrome 100, Edge 100. Support for browsers prior to these versions is "best effort" (bug reports on older browsers will be assessed individually and may be marked as wontfix). #### What's Changed - feat: use chaijs/loupe for inspection by [@​pcorpet](https://redirect.github.com/pcorpet) in [https://github.com/chaijs/chai/pull/1401](https://redirect.github.com/chaijs/chai/pull/1401) - docs: fix URL in README by [@​Izzur](https://redirect.github.com/Izzur) in [https://github.com/chaijs/chai/pull/1413](https://redirect.github.com/chaijs/chai/pull/1413) - Remove `get-func-name` dependency by [@​koddsson](https://redirect.github.com/koddsson) in [https://github.com/chaijs/chai/pull/1416](https://redirect.github.com/chaijs/chai/pull/1416) - Convert Makefile script to npm scripts by [@​koddsson](https://redirect.github.com/koddsson) in [https://github.com/chaijs/chai/pull/1424](https://redirect.github.com/chaijs/chai/pull/1424) - Clean up README badges by [@​koddsson](https://redirect.github.com/koddsson) in [https://github.com/chaijs/chai/pull/1422](https://redirect.github.com/chaijs/chai/pull/1422) - fix: package.json - deprecation warning on exports field by [@​stevenjoezhang](https://redirect.github.com/stevenjoezhang) in [https://github.com/chaijs/chai/pull/1400](https://redirect.github.com/chaijs/chai/pull/1400) - fix: deep-eql bump package to support symbols by [@​snewcomer](https://redirect.github.com/snewcomer) in [https://github.com/chaijs/chai/pull/1458](https://redirect.github.com/chaijs/chai/pull/1458) - ES module conversion PoC by [@​43081j](https://redirect.github.com/43081j) in [https://github.com/chaijs/chai/pull/1498](https://redirect.github.com/chaijs/chai/pull/1498) - chore: drop commonjs support by [@​43081j](https://redirect.github.com/43081j) in [https://github.com/chaijs/chai/pull/1503](https://redirect.github.com/chaijs/chai/pull/1503) - Update pathval by [@​koddsson](https://redirect.github.com/koddsson) in [https://github.com/chaijs/chai/pull/1527](https://redirect.github.com/chaijs/chai/pull/1527) - Update check-error by [@​koddsson](https://redirect.github.com/koddsson) in [https://github.com/chaijs/chai/pull/1528](https://redirect.github.com/chaijs/chai/pull/1528) - update `deep-eql` to latest version by [@​koddsson](https://redirect.github.com/koddsson) in [https://github.com/chaijs/chai/pull/1542](https://redirect.github.com/chaijs/chai/pull/1542) - Inline `type-detect` as a simple function by [@​koddsson](https://redirect.github.com/koddsson) in [https://github.com/chaijs/chai/pull/1544](https://redirect.github.com/chaijs/chai/pull/1544) - Update loupe by [@​koddsson](https://redirect.github.com/koddsson) in [https://github.com/chaijs/chai/pull/1545](https://redirect.github.com/chaijs/chai/pull/1545) - Typo 'Test an object' not 'Test and object' by [@​mavaddat](https://redirect.github.com/mavaddat) in [https://github.com/chaijs/chai/pull/1460](https://redirect.github.com/chaijs/chai/pull/1460) - Update `assertion-error` to it's latest major version! by [@​koddsson](https://redirect.github.com/koddsson) in [https://github.com/chaijs/chai/pull/1543](https://redirect.github.com/chaijs/chai/pull/1543) - Replacing Karma with Web Test Runner by [@​koddsson](https://redirect.github.com/koddsson) in [https://github.com/chaijs/chai/pull/1546](https://redirect.github.com/chaijs/chai/pull/1546) #### New Contributors - [@​Izzur](https://redirect.github.com/Izzur) made their first contribution in [https://github.com/chaijs/chai/pull/1413](https://redirect.github.com/chaijs/chai/pull/1413) - [@​stevenjoezhang](https://redirect.github.com/stevenjoezhang) made their first contribution in [https://github.com/chaijs/chai/pull/1400](https://redirect.github.com/chaijs/chai/pull/1400) - [@​43081j](https://redirect.github.com/43081j) made their first contribution in [https://github.com/chaijs/chai/pull/1498](https://redirect.github.com/chaijs/chai/pull/1498) **Full Changelog**: chaijs/chai@4.3.1...v5.0.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR was generated by [Mend Renovate](https://mend.io/renovate/). View the [repository job log](https://developer.mend.io/github/davidsneighbour/hugo-modules). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOC43NC4xIiwidXBkYXRlZEluVmVyIjoiMzguNzQuMSIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOltdfQ==--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
I'm sure there's plenty of other things to take into account, tests to add (such that we test both CJS/ESM equally) and maybe some problems in this I missed - however, here's a PoC of converting the codebase to ESM.
As the commit says, it uses esbuild under the hood to create two bundled entrypoints:
chai.js
- ESMchai.cjs
- CommonJSTwo because there are still dependencies written in CommonJS, which invalidates the ESM-only tree (meaning you wouldn't be able to use it natively in a browser). Bundling them means we can leave it up to esbuild to figure the dependencies out and ship pure ESM.
If you ever want this or feel like picking it up, let me know, i can probably find a little time to pair on it some way.
The diff's a little funky because I first caught up from 4.x.x into my 5.x.x-based branch, while the current 5.x.x branch is actually out of date (and I fixed the conflicts there).
Also, it'd probably break the
use
function externally (haven't tried it). has no use anymore internally but who knows what third party packages are depending on it. tried to imitate it with some mock exports object but haven't really tested it.i have tested it with a few chai plugins to see if
use
works, and all seems fine.