isAtLeast, isAtMost assertions added to assert interface #500
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wraithan
force-pushed
the
add-assert-gte-lte
branch
from
9568768
to
3c681e2
Compare
|
Hey @wraithan thanks for the PR, good work 👍 |
keithamus
added a commit
that referenced
this pull request
Jul 24, 2015
isAtLeast, isAtMost assertions added to assert interface
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed the
assertinterface was missing these methods. One can use theoperatormethod but that feels clunky. TheCONTRIBUTING.mdsays to not expand the interface without asking due to possible rejection. I'm 100% fine with this being rejected if the expansion of the interface is deemed not useful. I attempted to match style best I could but there is no linter so I'm not 100% positive I've hit every point.Also, it'd be nice if the
CONTRIBUTING.mdwas expanded to discuss whether one should include an updatedchai.jsor not. I assumed not since that appeared to be part of the release process but I wasn't sure.I went with is* for these to match the rest of the
assert, I'm happy to rename them to something else that y'all like. I started withmostandleastlike theshould/expectinterfaces but decided matching the interface I was adding them to was more important than matching what the other interfaces call them.I also opted to not add the aliases
gteandlteas there didn't appear to be any other shorthand aliases inassert. Happy to add those as well if those are desired.Thanks for ChaiJS