Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
Notes:
expected
andactual
array of keys were being sorted in theassertKeys
function usingArray.prototype.sort
but this throws a TypeError when one of the keys is a Symbol in a Map or a Set.NaN
block because JavaScript's isNaN() throws a TypeError when passed a Symbol. I don't know if Chai is supposed to mimic this behavior with its NaN test or instead return true?typeof this === 'symbol'
approach mentioned in [ES6] should.equal fails for Symbols #669 becausethis
is wrapped in an object and thus returns 'object' as its typeof.