Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix REINFORCE's missing initialization of t #133

Merged
merged 2 commits into from
Aug 14, 2017
Merged

Fix REINFORCE's missing initialization of t #133

merged 2 commits into from
Aug 14, 2017

Conversation

muupan
Copy link
Member

@muupan muupan commented Aug 12, 2017

REINFORCE doesn't have code to initialize self.t. The problem has been not found because chainer.experiemnts.train_agent sets it, but agents should be self-contained.

@coveralls
Copy link

coveralls commented Aug 12, 2017 •
edited
Loading

Coverage Status

Coverage increased (+0.01%) to 71.525% when pulling 6e5a072 on muupan:set_t into badf424 on chainer:master.

@toslunar
Copy link
Member

Nice catch and good job.

BTW, ChainerRL doesn't have rules for Agent.t (see e.g. #135), while I believe the PR does the best at this moment.

@toslunar toslunar merged commit 8d312bd into chainer:master Aug 14, 2017
@muupan muupan added the bug label Nov 30, 2017
@muupan muupan added this to the v0.3 milestone Nov 30, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
v0.3
Development

Successfully merging this pull request may close these issues.
3 participants
@muupan @coveralls @toslunar