Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve deterministic policies #173

Merged
merged 8 commits into from
Nov 22, 2017
Merged

Improve deterministic policies #173

merged 8 commits into from
Nov 22, 2017

Conversation

muupan
Copy link
Member

@muupan muupan commented Nov 15, 2017

Please merge this after #171 and #172 are merged.

  • Add nonlinearity and last_wscale to deterministic policies.
  • Improve docstrings
  • Add tests for deterministic policies

@muupan muupan changed the title Improve deterministic policies [WIP] Improve deterministic policies Nov 15, 2017
@muupan muupan changed the title [WIP] Improve deterministic policies Improve deterministic policies Nov 16, 2017
toslunar
toslunar reviewed Nov 22, 2017
View reviewed changes
Copy link
Member

@toslunar toslunar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The commits on chainerrl/policies/deterministic_policy.py looks good to me.
I simplified the test code. Could you confirm it?

@muupan
Copy link
Member Author

muupan commented Nov 22, 2017

LGTM

@muupan muupan merged commit 66e2a03 into chainer:master Nov 22, 2017
@muupan muupan deleted the improve-det-policy branch November 22, 2017 12:04
@muupan muupan added this to the v0.3 milestone Nov 30, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@toslunar toslunar toslunar left review comments

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
v0.3
Development

Successfully merging this pull request may close these issues.
2 participants
@muupan @toslunar