Fix QuadraticActionValue and add tests #190
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
muupan
requested changes
Nov 30, 2017
tests/test_action_value.py
Outdated
| # Otherwise, v_out[i] should be less than v[i] | ||
| np.testing.assert_array_less( | ||
| v_out[~mu_is_allowed], | ||
| v[~mu_is_allowed] + 1e-4) |
There was a problem hiding this comment.
How about asserting v_out[~mu_is_allowed] is strictly smaller than v[~mu_is_allowed], by removing + 1e-4? The current assertion doesn't fail if they have the same values i.e. min_action and max_action are not used at all.
muupan
approved these changes
Dec 1, 2017
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
QuadraticActionValuecalled withmin_action=Noneormax_action=Noneseems to have a bug.Note: