Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

except both Exception and KeyboardInterrupt #250

Merged
merged 1 commit into from
Mar 20, 2018
Merged

except both Exception and KeyboardInterrupt #250

merged 1 commit into from
Mar 20, 2018

Conversation

uenoku
Copy link
Contributor

@uenoku uenoku commented Mar 18, 2018

In experiments/train_agent.py, line 84, it handles only Exception. But in experiments/train_agent_async.py, it handles only KeyboardInterrupt. I think these should handle both.

Copy link
Member

@toslunar toslunar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@muupan muupan merged commit c47a75c into chainer:master Mar 20, 2018
@muupan muupan added the bug label Jul 23, 2018
@muupan muupan added this to the v0.4 milestone Jul 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants