Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove GaussianPolicy and obsolete policies #305

Merged
merged 2 commits into from
Oct 4, 2018

Conversation

muupan
Copy link
Member

@muupan muupan commented Sep 4, 2018

Resolves #276 and #281

Since LinearGaussianPolicyWithDiagonalCovariance hard-codes squashing actions by tanh, replacing it with FCGaussianPolicy will change the behavior. I confirmed that train_a3c_gym.py can solve InvertedPendulum-v1 as before by running python train_a3c_gym.py 4 --env InvertedPendulum-v1 --arch LSTMGaussian --t-max 50.

@muupan muupan changed the title [WIP] Remove Gaussian Policy and obsolete policies [WIP] Remove GaussianPolicy and obsolete policies Sep 4, 2018
@muupan muupan changed the title [WIP] Remove GaussianPolicy and obsolete policies Remove GaussianPolicy and obsolete policies Sep 4, 2018
Copy link
Contributor

@prabhatnagarajan prabhatnagarajan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM;

@muupan muupan merged commit 645bb2f into chainer:master Oct 4, 2018
@muupan muupan deleted the refactor-gaussian-policy branch October 4, 2018 10:15
@muupan muupan added this to the v0.5 milestone Nov 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants