Make random access queue sampling code cleaner #309
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have previously overridden the getitem operator. However, the sampling method doesn't make use of this override, and instead replicates much of the code in that method. This commit does change the semantics of what occurs in practice. However, due to the uniformity of sampling, in expectation it does the same thing. In a nutshell, both the previous code as well as this commit implement uniform sampling. However, the indexes that are chosen are different between the previous code and this one.