Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the error caused by inexact delta_z #314

Merged
merged 2 commits into from
Oct 31, 2018
Merged

Fix the error caused by inexact delta_z #314

merged 2 commits into from
Oct 31, 2018

Conversation

muupan
Copy link
Member

@muupan muupan commented Sep 28, 2018 •
edited
Loading

  • check if the performance is affected

@muupan
Copy link
Member Author

muupan commented Oct 5, 2018

Good news. This fix actually seems to boost performance.

image
image
image

@muupan muupan changed the title [WIP] Fix the error caused by inexact delta_z Fix the error caused by inexact delta_z Oct 5, 2018
@prabhatnagarajan prabhatnagarajan self-assigned this Oct 9, 2018
prabhatnagarajan
prabhatnagarajan approved these changes Oct 31, 2018
View reviewed changes
Copy link
Contributor

@prabhatnagarajan prabhatnagarajan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two points

  1. If you can use Tz in the apply_categorical_projection method instead of 'y', that would be helpful.
  2. If you could move delta_z variable setting closer to where it is used, that would be helpful.

@muupan muupan merged commit 8d7004b into chainer:master Oct 31, 2018
@muupan muupan deleted the fix-categorical-dqn-error branch October 31, 2018 07:39
@muupan muupan modified the milestone: v0.5 Nov 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prabhatnagarajan prabhatnagarajan prabhatnagarajan approved these changes

Assignees

@prabhatnagarajan prabhatnagarajan

Labels
bug no-compat
Projects
None yet
Milestone
v0.5
Development

Successfully merging this pull request may close these issues.
2 participants
@muupan @prabhatnagarajan