Use AbnormalExitCodeWarning for nonzero exitcode warnings #378
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 8, 2019
toslunar
reviewed
Jan 8, 2019
chainerrl/misc/async_.py
Outdated
| @@ -15,6 +15,11 @@ | |||
| from chainerrl.misc import random_seed | |||
|
|
|||
|
|
|||
| class AbnormalExitCodeWarning(Warning): | |||
There was a problem hiding this comment.
How about AbnormalExitWarning or AbnormalTerminationWarning? A nonzero Process.exitcode represents either an exitcode or a signal.
There was a problem hiding this comment.
Sounds good. I renamed it to AbnormalExitWarning which is shorter.
toslunar
approved these changes
Jan 8, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When subprocesses exit with nonzero exitcode,
run_asyncraise warnings. Some tests check the number of warnings, but they do not work when there is another code that raises warnings, leading to failure in CI of current master.This PR specifies a warning category for nonzero exitcode,
AbnormalExitCodeWarning, and the tests will check warnings of that category.