Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make IQN work with tuple observations #435

Merged
merged 1 commit into from
Apr 5, 2019
Merged

Make IQN work with tuple observations #435

merged 1 commit into from
Apr 5, 2019

Conversation

muupan
Copy link
Member

@muupan muupan commented Apr 5, 2019

batch_next_state may not be an ndarray, e.g., when observations are tuples of ndarrays. To avoid an error caused by this, use exp_batch['reward'] to get the batch size since it is always an ndarray

toslunar
toslunar approved these changes Apr 5, 2019
View reviewed changes
Copy link
Member

@toslunar toslunar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@muupan muupan merged commit e6e47d3 into chainer:master Apr 5, 2019
@muupan muupan deleted the iqn-tuple-obs branch April 5, 2019 11:35
@muupan muupan added this to the v0.7 milestone Jun 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@toslunar toslunar toslunar approved these changes

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
v0.7
Development

Successfully merging this pull request may close these issues.
2 participants
@muupan @toslunar